[XERCESC-1379] XSSimpleTypeDefinition constructor - declaration and definition of a variable at the "if" check causes compiler error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Environment: Solaris 2.8 with SPARCompiler 4.2
• Assignee: Unassigned
• Reporter: Maciek Samsel
• Created: 17/Mar/05 05:48
• Updated: 12/Mar/18 04:05
• Resolved: 17/Mar/05 17:27

Description

Line 100, File: xerces-c-src_2_6_0/src/xercesc/framework/psvi/XSSimpleTypeDefinition.cpp

This is bad style of programming and what's more it will not work with a few compilers. You are not supposed to define and assign value inside "if" construct. Commercial SPARCompiler 4.2 reports error of malformed line and does not allow to complete.

Although rich language syntax of C++ allows for many approaches some of them are not the best and should be avoided. The readabilty of the code is the main principle as we departure from obfuscated ways of writing expressions inherited from C programming styles like 20 years ago.

Please fix line:
if (int finalset = fDatatypeValidator->getFinalSet())

replacing it with:
int finalset = fDatatypeValidator->getFinalSet();
if (finalset)

(it is a local variable used in that block only so there is no conflicts).

Anyway how much performance do you gain with that check? (see the code after it)