[XBEAN-337] jar path with exclamation signs(!) should be resolved correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Resolved
• Affects Version/s: 4.22
• Fix Version/s: 4.23
• Component/s: finder
• Labels: pull-request-available

Language

java

• Assignee: Unassigned
• Reporter: KDV
• Created: 10/Dec/22 19:22
• Updated: 11/May/23 19:01
• Resolved: 11/May/23 19:01

Description

The fragment of org.apache.xbean.finder.archive.JarArchive() constructor incorrectly resolves paths with exclamation signs:

            if (jarPath.contains("!")) {
                jarPath = jarPath.substring(0, jarPath.indexOf("!"));
                u = new URL(jarPath);
            }
            jar = new JarFile(FileArchive.decode(u.getFile()));

where
E:/!IDE/Eclipse-JEE-2022-12-R/configuration/lib/javaagent-shaded.jar!/
turns into E:/ and causes FileNotFound exception failure.

Since exclamation sign(!) is a valid path character, jar file path should be cut by jarPath.lastIndexOf("!") or better(?) jarPath.toLowerCase().indexOf(".jar!") + 4

Issue Links

• links to: GitHub Pull Request #34