[XALANJ-666] SAXSourceLocator Not Reporting Location Correctly

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.2.0
• Component/s: Other
• Environment: Operating System: Windows NT/2K; Platform: PC
• Bugzilla Id: 4796
• Assignee: Scott Boag
• Reporter: Peter Bryant
• Created: 11/Nov/01 17:39
• Updated: 11/Aug/05 12:38

Description

In the constructor:
public SAXSourceLocator(Locator locator)

{ m_locator = locator; this.setColumnNumber(locator.getColumnNumber()); this.setLineNumber(locator.getLineNumber()); this.setPublicId(locator.getPublicId()); this.setSystemId(locator.getSystemId()); }

The correct values are being set.

However, in the 'get' methods (e.g.)
public int getColumnNumber()

{ return (null == m_locator) ? super.getColumnNumber() : m_locator.getColumnNumber(); }

it appears that values in m_locator have changed and no longer have the values
they had upon initialisation.

I would suggest that m_locator is removed from this class (and its values only
unsed during construction). This would make this class immutable. And the get
methods would simply be:

public int getColumnNumber()

{ return super.getColumnNumber(); }

er, or even unneccesary (just rely on superclass implementation).