[WW-5475] Struts 7: improve error when "s:action" is used on jsp page and jsp is invoked directly in browser

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 7.0.0
• Fix Version/s: 7.0.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Wolfgang Knauf
• Created: 20/Oct/24 10:04
• Updated: 27/Oct/24 15:43

Description

I have a "index.jsp" and invoke an action using "s:action" tag, then render data from this action. In the browser I navigate to this jsp direcly ("http://localhost/index.jsp" instead of browsing to ".../index.action").

Snippet from my JSP:

<s:action name="myAction" var="myActionResult">
  ...
  <s:iterator value="#myActionResult.items">
      </s:iterator><table><tbody>
    <tr>
        <td>
          <s:property value="a">
        </s:property></td>
        <td>
          <s:property value="b">
        </s:property></td>
        <td>
          <s:property value="c">
        </s:property></td>
      </tr>  </tbody>
</table>

This worked with Struts 2. But when migrating this to Struts 7M9, this error is reported on the server console:

 

11:54:55,939 ERROR [io.undertow.request] (default task-1) UT005023: Exception handling request to /Struts7Sample/: org.apache.jasper.JasperException: java.lang.NullPointerException: Cannot invoke "com.opensymphony.xwork2.ActionInvocation.getProxy()" because "invocation" is null
    at [e-mail]//org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:461)
    at [e-mail]//org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403)
    at [e-mail]//org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347)
    at jakarta.servlet.api@6.0.0//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
    at [e-mail]//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
    at [e-mail]//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
    at deployment.Struts7Sample.war//org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.handleRequest(StrutsPrepareAndExecuteFilter.java:149)
    at deployment.Struts7Sample.war//org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.tryHandleRequest(StrutsPrepareAndExecuteFilter.java:135)
    at deployment.Struts7Sample.war//org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:123)
    at [e-mail]//io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:67)
    at [e-mail]//io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
    at [e-mail]//io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84)
    at [e-mail]//io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
    at [e-mail]//io.undertow.jsp.JspFileHandler.handleRequest(JspFileHandler.java:32)
    at [e-mail]//io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
    at [e-mail]//io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
    at [e-mail]//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.lambda$handleRequest$1(ElytronRunAsHandler.java:68)
    at [e-mail]//org.wildfly.security.auth.server.FlexibleIdentityAssociation.runAsFunctionEx(FlexibleIdentityAssociation.java:103)
    at [e-mail]//org.wildfly.security.auth.server.Scoped.runAsFunctionEx(Scoped.java:161)
    at [e-mail]//org.wildfly.security.auth.server.Scoped.runAs(Scoped.java:73)
    at [e-mail]//org.wildfly.elytron.web.undertow.server.ElytronRunAsHandler.handleRequest(ElytronRunAsHandler.java:67)
    at [e-mail]//io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68)
    at [e-mail]//io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:117)
    at [e-mail]//io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
    at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
    at [e-mail]//io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
    at [e-mail]//io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
    at [e-mail]//io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
    at [e-mail]//org.wildfly.elytron.web.undertow.server.servlet.CleanUpHandler.handleRequest(CleanUpHandler.java:38)
    at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
    at [e-mail]//org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:44)
    at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
    at [e-mail]//org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:51)
    at [e-mail]//io.undertow.servlet.handlers.SendErrorPageHandler.handleRequest(SendErrorPageHandler.java:52)
    at [e-mail]//io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
    at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:276)
    at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
    at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:132)
    at [e-mail]//io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
    at [e-mail]//io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
    at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1421)
    at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1421)
    at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1421)
    at [e-mail]//org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1421)
    at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:256)
    at [e-mail]//io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:101)
    at [e-mail]//io.undertow.server.Connectors.executeRootHandler(Connectors.java:393)
    at [e-mail]//io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:859)
    at [e-mail]//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
    at [e-mail]//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
    at [e-mail]//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
    at [e-mail]//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
    at [e-mail]//org.xnio.XnioWorker$WorkerThreadFactory$1$1.run(XnioWorker.java:1282)
    at java.base/java.lang.Thread.run(Thread.java:842)
Caused by: java.lang.NullPointerException: Cannot invoke "com.opensymphony.xwork2.ActionInvocation.getProxy()" because "invocation" is null
    at deployment.Struts7Sample.war//org.apache.struts2.components.Component.getNamespace(Component.java:448)
    at deployment.Struts7Sample.war//org.apache.struts2.components.ActionComponent.executeAction(ActionComponent.java:252)
    at deployment.Struts7Sample.war//org.apache.struts2.components.ActionComponent.end(ActionComponent.java:166)
    at deployment.Struts7Sample.war//org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
    at org.apache.jsp.index_jsp._jspx_meth_s_005faction_005f0(index_jsp.java:170)
    at org.apache.jsp.index_jsp._jspService(index_jsp.java:116)
    at [e-mail]//org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
    at jakarta.servlet.api@6.0.0//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
    at [e-mail]//org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:422)
    ... 53 more

 

The browser renders an empty page in this situation.

I was told (question on the mailing list) that direct access to a jsp is not supported. This issue is about creating a helpful error message instead of printing a (meaningless) exception on the console.

 

Attached are two sample apps, one for Struts 2 (runs on a WildFly 26 server) and Struts 7.0 M9 (WildFly 33 server). Reproduce the error by calling "http://localhost:8080/Struts7Sample/index.jsp". It works when invoking "http://localhost:8080/Struts7Sample/index.action".

The war files contain the sources for the actions, and also all necessary Struts jars. You can import it to Eclipse by using the type "Import" => "Web" => "WAR file"