[WW-5437] EnvsValueSubstitutor ignores Environment variables if default value is present

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.4.0
• Fix Version/s: 6.6.0
• Component/s: XML Configuration
• External issue URL: https://github.com/apache/struts/pull/977
• Assignee: Unassigned
• Reporter: Stefan Sielaff
• Created: 02/Jul/24 14:01
• Updated: 30/Aug/24 11:33
• Resolved: 05/Jul/24 04:52

Description

According to the documentation at https://struts.apache.org/core-developers/constant-configuration it should be possible to use both system and environment variables in the constants section. Currently environment variables are ignored if a default value is defined.

The sysStrSubstitutor has a less specific prefix which also includes and replaces those, which should be passed to the envStrSubstitutor later.

Given

System.getenv('STRUTS_DEV_MODE') is "true"

<constant name="struts.devMode" value="${env.STRUTS_DEV_MODE:false}"/>

The code:

String substituted = sysStrSubstitutor.replace(value);
return envStrSubstitutor.replace(substituted);

The sysStrSubstitutor checks, if there is a system property with the key "env.STRUTS_DEV_MODE" which is unset. It then replaces the expression with its default. substituted is "false" now. Afterwards the envStrSubstitutor doesn't find any expression to substitute, because the string is "false".

Issue Links

• links to: Github PR #977
• links to: GitHub Pull Request #977