[WW-5359] Improved the StrutsUrlDecoder so that charset retrieval is performed only once

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.1.1
• Fix Version/s: 6.4.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Tatsuo Tsuchie
• Created: 25/Oct/23 10:03
• Updated: 20/Apr/24 11:59
• Resolved: 25/Oct/23 10:12

Description

• StutsUrlDecoder has performance problems when run from multiple threads, because Charset#availavleCharts(...) called StrutsUrlDecoder#getCharset(...) is synchronized blocked.
  • Root causes is synchronized blocked at AbstractCharsetProvider#charsets() .
  • StutsUrlDecoder is used to evaluate custom tag <s:url>, it will have performance problems if it receives too many requests.
• Therefore, Charset#availavleCharts(...) to be executed only once during the StrutsUrlDecoder initialization.

Issue Links

• links to: GitHub Pull Request #773