Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-5288

Make excluded package exemption logic more strict

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 6.2.0
    • Core
    • None

    Description

      Following on from the discussion in the comments on WW-5268 - exempting classes from excluded packages should only be done if unavoidable.

      Given this, I realised we should make the exemption logic more strict to prevent incorrect use and inadvertent exempting of more OGNL expressions than intended.

      • Currently, the exempted classes also match against superclasses. This is unnecessary and we can match against only the specific class.
      • Currently, an exemption against either the target or member class suffices. This can be made more strict by requiring an exemption for the class which matches the excluded package specifically, which could be either or both.
      • The JavaDoc for the options should be very explicit in what each configuration option achieves to prevent incorrect uses.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kusal Kusal Kithul-Godage
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 10m
                  3h 10m