[WW-5146] Empty file upload ends in error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 2.5.26
• Fix Version/s: 6.0.0
• Component/s: Core Interceptors
• Labels: upload

Language

java

• Assignee: Unassigned
• Reporter: KON-SUN-TACK
• Created: 25/Oct/21 06:36
• Updated: 14/Jun/22 09:47
• Resolved: 12/Nov/21 14:13

Description

After upgrading to 2.5.26, uploading an empty file now ends with: "Error uploading: empty_file.txt"
This was working fine with Struts 2.5.20
Seems the behavior change occurred somewhere in 2.5.22 - 2.5.5.25

In org.apache.struts2.dispatcher.multipart.JakartaMultiPartRequest:

protected DiskFileItemFactory createDiskFileItemFactory(String saveDir) {
   DiskFileItemFactory fac = new DiskFileItemFactory();
   // Make sure that the data is written to file
   fac.setSizeThreshold(0);
   if (saveDir != null) {
     fac.setRepository(new File(saveDir));
   }
   return fac;
 }

For an empty file, seeing org.apache.commons.io.output.ThresholdingOutputStream checking threshold with an "greater than" operator (>),
I guess "fac.setSizeThreshold(0);" does not actually make sure the data is written to a file (hence getting null storeLocation)

See also https://issues.apache.org/jira/browse/WW-5088

Issue Links

• duplicates: WW-5088 Empty file upload gives wrong error message