[WW-4995] Enhancement for s:set tag to improve tag body whitespace control.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.18
• Fix Version/s: 2.5.20, 6.0.0
• Component/s: Core Tags
• Labels: pull-request-available

Environment

All environments.

• Assignee: Unassigned
• Reporter: James Chaplin
• Created: 17/Dec/18 05:27
• Updated: 02/Nov/21 06:08
• Resolved: 29/Dec/18 16:22

Description

Hello Apache Struts Team.

The current s:set tag performs an automatic trim() on any body content used (when using the <s:set>something</s:set> style with a body).

The current behaviour limits white-space control for the text body passed to the s:set tag (and makes assigning a single-or-muliple-character whitespace set - e.g. "  " impossible via the tag body)..

A proposed improvement is to introduce two optional attributes to the s:set tag which will permit the following:

• Allow an override to prevent the trim() from happening (helps to preserve existing whitespace)..
• Allow the optional removal of all line-breaks from the tag body content (to allow vertical collapsing of tag body content without impacting anything else).

There is a PR available with a proposed implementation for the enhancement.  I believe having this additional flexibility will be beneficial for some JSP content generation scenarios.

Please review and advise if this minor enhancement can be considered for inclusion in 2.5.19 (and then ported forward for 2.6).

Issue Links

• links to: GitHub PR #296
• links to: GitHub PR #299