[WW-4908] Conversion by annotation does not work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.34, 2.5.14.1
• Fix Version/s: 2.5.16
• Component/s: Core
• Labels: annotation conversion
• Flags: Patch
• Assignee: Yasser Zamani
• Reporter: Yasser Zamani
• Created: 10/Jan/18 10:49
• Updated: 16/Mar/18 13:24
• Resolved: 15/Jan/18 10:51

Description

It's because of following bugs:

DefaultConversionAnnotationProcessor.java

//for properties of classes
else if (tc.rule() != ConversionRule.ELEMENT || tc.rule() == ConversionRule.KEY || tc.rule() == ConversionRule.COLLECTION)

wrong statement for handling properties (badly imported from DefaultConversionFileProcessor.java).

XWorkConverter.java

// Default to the property name
if (StringUtils.isEmpty(key)) {

should also add prefix to key like what are inside XXX-validation.properties files!

Issue Links

• links to: GitHub Pull Request #199