[WW-4865] Struts s:checkbox conversion fails to List<Integer>

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.13
• Fix Version/s: 6.0.0
• Component/s: Core, Core Tags
• Assignee: Unassigned
• Reporter: Burton Rhodes
• Created: 02/Oct/17 16:39
• Updated: 30/Sep/22 14:18
• Resolved: 23/Mar/18 20:38

Description

Struts <s:checkbox> is not converted correctly to List<Integer> when only one checkbox element is present and checkbox is not checked.

[Given]
1) Mapping s:checkbox to a List<Integer>
2) there is only one checkbox in the list
3) the checkbox is not checked when the form is submitted.

[Result]
Input invalid

The issue is caused by the checkbox tag using the "submit unchecked values" design pattern. As a result, the code base tries to convert the value of the single unchecked element to false (rather than not setting any value of the List<Integer>).

Fix: Allow the developer to choose if the "submit unchecked values" is to be implemented. Add a new parameter to the s:checkbox tag ("requiredValue"). Default of requiredValue=true for backwards compatibility. When set to false, no hidden input values will be displayed in the view. This flexibility might be needed in other scenarios as well.

Pull Request: https://github.com/apache/struts/pull/169

Issue Links

• relates to: WW-5239 regression btw struts 2.5.30 and 6.0.30 / submit s:checkbox unchecked -> NPE
• links to: GitHub Pull Request #169