Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4838

expose Freemarker incompatible_improvements into FreemarkerManager and StrutsBeansWrapper

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.12
    • Fix Version/s: 2.5.13
    • Component/s: Plugin - SiteMesh
    • Labels:
      None

      Description

      The latest version of Freemarker (2.3.6) supports the use of default methods in interfaces when communicating between beans and the Freemarker template.

      To enable this, it's required to allow init parameters to be passed from the servlet configuration in through to the FreemarkerManager and the BeansWrapper. The sitemesh plugin prevents the setting of these parameters because it doesn't appear to pass the parameters in through.

      Note: I'm not arguing that we should just "change these parameters, but it'd be nice to be able to pass the <init-param> configuration through to Freemarker

        Activity

        Hide
        lukaszlenart Lukasz Lenart added a comment - - edited

        You should be able to pass that via freemarker.properties

        https://struts.apache.org/docs/freemarker.html#FreeMarker-IncompatibleImprovements

        Show
        lukaszlenart Lukasz Lenart added a comment - - edited You should be able to pass that via freemarker.properties https://struts.apache.org/docs/freemarker.html#FreeMarker-IncompatibleImprovements
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 68cb702dc8b13eb0e948a59cc3e274206019c642 in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=68cb702 ]

        WW-4838 Allows define incompatible improvements as an init-param

        Show
        jira-bot ASF subversion and git services added a comment - Commit 68cb702dc8b13eb0e948a59cc3e274206019c642 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=68cb702 ] WW-4838 Allows define incompatible improvements as an init-param
        Show
        lukaszlenart Lukasz Lenart added a comment - Docs updated as well https://cwiki.apache.org/confluence/display/WW/FreeMarker#FreeMarker-IncompatibleImprovements
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #22 (See https://builds.apache.org/job/Struts-master-JDK7/22/)
        WW-4838 Allows define incompatible improvements as an init-param (lukaszlenart: rev 68cb702dc8b13eb0e948a59cc3e274206019c642)

        • (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java
        • (edit) core/src/main/java/org/apache/struts2/views/freemarker/StrutsBeanWrapper.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #22 (See https://builds.apache.org/job/Struts-master-JDK7/22/ ) WW-4838 Allows define incompatible improvements as an init-param (lukaszlenart: rev 68cb702dc8b13eb0e948a59cc3e274206019c642) (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java (edit) core/src/main/java/org/apache/struts2/views/freemarker/StrutsBeanWrapper.java

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            abrin adam brin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development