Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.12
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user sdutry opened a pull request:

        https://github.com/apache/struts/pull/132

        WW-4780 : upgraded version of log4j2 to 2.8.2

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/sdutry/struts WW-4780

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/132.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #132


        commit 11cccb68a90edb73ce183c4bb735cb458bfe9ec5
        Author: Stefaan Dutry <stefaan.dutry@gmail.com>
        Date: 2017-04-20T20:06:20Z

        upgraded version of log4j2 to 2.8.2


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user sdutry opened a pull request: https://github.com/apache/struts/pull/132 WW-4780 : upgraded version of log4j2 to 2.8.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sdutry/struts WW-4780 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 11cccb68a90edb73ce183c4bb735cb458bfe9ec5 Author: Stefaan Dutry <stefaan.dutry@gmail.com> Date: 2017-04-20T20:06:20Z upgraded version of log4j2 to 2.8.2
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/struts/pull/132

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/132
        Hide
        sdutry Stefaan Dutry added a comment -

        Done.

        Lukasz Lenart
        I notice that the plugin modules struts2-cdi-plugin and struts2-portlet-plugin still have references to: log4j:log4j:jar:1.2.17 for the test-scope.
        Should these be looked at to try and remove these dependencies?

        Show
        sdutry Stefaan Dutry added a comment - Done. Lukasz Lenart I notice that the plugin modules struts2-cdi-plugin and struts2-portlet-plugin still have references to: log4j:log4j:jar:1.2.17 for the test-scope. Should these be looked at to try and remove these dependencies?
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        yes, please try to drop them

        Show
        lukaszlenart Lukasz Lenart added a comment - yes, please try to drop them
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the issue:

        https://github.com/apache/struts/pull/132

        Small changes like this you can directly push to the `master` branch, opening PR and merging it, is time-consuming

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/132 Small changes like this you can directly push to the `master` branch, opening PR and merging it, is time-consuming
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user sdutry commented on the issue:

        https://github.com/apache/struts/pull/132

        @lukaszlenart
        I know they can.
        I just like having the confirmation from the automated build tools (jenkins and travis) that i didn't break the builds before committing.

        Show
        githubbot ASF GitHub Bot added a comment - Github user sdutry commented on the issue: https://github.com/apache/struts/pull/132 @lukaszlenart I know they can. I just like having the confirmation from the automated build tools (jenkins and travis) that i didn't break the builds before committing.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the issue:

        https://github.com/apache/struts/pull/132

        ah... cool

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/132 ah... cool
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit defaf43a4c27ca62b9ec8db5749ef4a6f80fc719 in struts's branch refs/heads/master from Stefaan Dutry
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=defaf43 ]

        WW-4780 fixed logging in the struts2-cdi-plugin tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit defaf43a4c27ca62b9ec8db5749ef4a6f80fc719 in struts's branch refs/heads/master from Stefaan Dutry [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=defaf43 ] WW-4780 fixed logging in the struts2-cdi-plugin tests
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b465791dc2097b24991da4b61245278a7b48c88c in struts's branch refs/heads/master from Stefaan Dutry
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=b465791 ]

        WW-4780 fixed logging in the struts2-portlet-plugin tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit b465791dc2097b24991da4b61245278a7b48c88c in struts's branch refs/heads/master from Stefaan Dutry [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=b465791 ] WW-4780 fixed logging in the struts2-portlet-plugin tests
        Hide
        sdutry Stefaan Dutry added a comment -

        Removed log4j dependencies and replaced them with log4j2 (including log configs).

        • struts2-cdi-plugin
        • struts2-portlet-plugin

        Issue should now be resolved.

        Show
        sdutry Stefaan Dutry added a comment - Removed log4j dependencies and replaced them with log4j2 (including log configs). struts2-cdi-plugin struts2-portlet-plugin Issue should now be resolved.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-JDK7-master #621 (See https://builds.apache.org/job/Struts-JDK7-master/621/)
        WW-4780 fixed logging in the struts2-cdi-plugin tests (stefaan.dutry: rev defaf43a4c27ca62b9ec8db5749ef4a6f80fc719)

        • (delete) plugins/cdi/src/test/resources/log4j.properties
        • (add) plugins/cdi/src/test/resources/log4j2.xml
        • (edit) plugins/cdi/pom.xml
          WW-4780 fixed logging in the struts2-portlet-plugin tests (stefaan.dutry: rev b465791dc2097b24991da4b61245278a7b48c88c)
        • (edit) plugins/portlet/pom.xml
        • (add) plugins/portlet/src/test/resources/log4j2.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #621 (See https://builds.apache.org/job/Struts-JDK7-master/621/ ) WW-4780 fixed logging in the struts2-cdi-plugin tests (stefaan.dutry: rev defaf43a4c27ca62b9ec8db5749ef4a6f80fc719) (delete) plugins/cdi/src/test/resources/log4j.properties (add) plugins/cdi/src/test/resources/log4j2.xml (edit) plugins/cdi/pom.xml WW-4780 fixed logging in the struts2-portlet-plugin tests (stefaan.dutry: rev b465791dc2097b24991da4b61245278a7b48c88c) (edit) plugins/portlet/pom.xml (add) plugins/portlet/src/test/resources/log4j2.xml
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        I think we can mark this issue as resolved, right?

        Show
        lukaszlenart Lukasz Lenart added a comment - I think we can mark this issue as resolved, right?
        Hide
        sdutry Stefaan Dutry added a comment -

        Lukasz Lenart
        I think so.

        Show
        sdutry Stefaan Dutry added a comment - Lukasz Lenart I think so.
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        PR merged, dependencies got cleared, thanks

        Show
        lukaszlenart Lukasz Lenart added a comment - PR merged, dependencies got cleared, thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-examples-JDK8-master #54 (See https://builds.apache.org/job/Struts-examples-JDK8-master/54/)
        updated log4j2 to version 2.8.2 (WW-4780) (stefaan.dutry: rev 51a2f18740c496424c5456bec417958d86fefe7f)

        • (edit) pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-examples-JDK8-master #54 (See https://builds.apache.org/job/Struts-examples-JDK8-master/54/ ) updated log4j2 to version 2.8.2 ( WW-4780 ) (stefaan.dutry: rev 51a2f18740c496424c5456bec417958d86fefe7f) (edit) pom.xml

          People

          • Assignee:
            Unassigned
            Reporter:
            lukaszlenart Lukasz Lenart
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development