Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4753

Make DelegatingValidatorContext injectable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.10
    • Fix Version/s: 2.5.12
    • Component/s: Core
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user lukaszlenart opened a pull request:

        https://github.com/apache/struts/pull/120

        WW-4753: Injectable context

        This PR converts statically created validation contexts into injectable beans. It's intermediate step to convert `LocalizedTextUtil` into a bean.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/lukaszlenart/struts injectable-context

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/120.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #120


        commit da5da67d8027ad2fd05e579c893a4a8a8acd728e
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T07:39:20Z

        Makes factory fully injectable

        commit db8ebe710d1aaa815006d070b9dda4930a9d152a
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T07:39:55Z

        Uses the new injectable factory to obtain TextProvider

        commit 728055dc46b2517791d5860d60a77e6196ddcbaf
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T07:40:24Z

        Adjust usage of the factory

        commit 89d95b64cd68b0b7d03f60249f6202dbb2e14b28
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:17:03Z

        Drops empty line

        commit 3be5aa0fdb23a69f7dabf3633ca8dd5d09f923dc
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:17:25Z

        Adds missing constructor param

        commit d7cf0609059c7ffe1f90cc044c9ea20536e823b2
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:20:39Z

        Defines new injectable bean with alias

        commit 3dc8480988f38f367f9965bad0ff60656d091fa9
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:20:57Z

        Updates test

        commit c063704d279b6dc7d349c232f17b3b2aebe19b99
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:21:24Z

        Renames class to match its purpose

        commit 57106ccda2207edb52e575e16cfd47599e9c7110
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:21:28Z

        Renames class to match its purpose

        commit 451eb883070100dfc57c7635ddc80c57f82f8169
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:37:19Z

        Adds missing anntoation to properly inject dependency

        commit f56c59c9829347255f5b161ac97dc51069b61fed
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:37:36Z

        Defines TextProviderFactory as a bean

        commit 55ea82cd4faaecf1f3ca1fffd4428db2471b952d
        Author: Lukasz Lenart <lukaszlenart@apache.org>
        Date: 2017-03-10T08:40:20Z

        Uses container to inject required dependencies


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/120 WW-4753 : Injectable context This PR converts statically created validation contexts into injectable beans. It's intermediate step to convert `LocalizedTextUtil` into a bean. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts injectable-context Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit da5da67d8027ad2fd05e579c893a4a8a8acd728e Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:39:20Z Makes factory fully injectable commit db8ebe710d1aaa815006d070b9dda4930a9d152a Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:39:55Z Uses the new injectable factory to obtain TextProvider commit 728055dc46b2517791d5860d60a77e6196ddcbaf Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:40:24Z Adjust usage of the factory commit 89d95b64cd68b0b7d03f60249f6202dbb2e14b28 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:17:03Z Drops empty line commit 3be5aa0fdb23a69f7dabf3633ca8dd5d09f923dc Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:17:25Z Adds missing constructor param commit d7cf0609059c7ffe1f90cc044c9ea20536e823b2 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:20:39Z Defines new injectable bean with alias commit 3dc8480988f38f367f9965bad0ff60656d091fa9 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:20:57Z Updates test commit c063704d279b6dc7d349c232f17b3b2aebe19b99 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:21:24Z Renames class to match its purpose commit 57106ccda2207edb52e575e16cfd47599e9c7110 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:21:28Z Renames class to match its purpose commit 451eb883070100dfc57c7635ddc80c57f82f8169 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:37:19Z Adds missing anntoation to properly inject dependency commit f56c59c9829347255f5b161ac97dc51069b61fed Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:37:36Z Defines TextProviderFactory as a bean commit 55ea82cd4faaecf1f3ca1fffd4428db2471b952d Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:40:20Z Uses container to inject required dependencies
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cnenning commented on the issue:

        https://github.com/apache/struts/pull/120

        Besides the failing test this looks good to me

        Show
        githubbot ASF GitHub Bot added a comment - Github user cnenning commented on the issue: https://github.com/apache/struts/pull/120 Besides the failing test this looks good to me
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the issue:

        https://github.com/apache/struts/pull/120

        Thanks but that failing test is 50% of work

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/120 Thanks but that failing test is 50% of work
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        The linked issue is a safety check of work performed in this issue

        Show
        lukaszlenart Lukasz Lenart added a comment - The linked issue is a safety check of work performed in this issue
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the issue:

        https://github.com/apache/struts/pull/120

        @cnenning done and wasn't that bad when I thought

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/120 @cnenning done and wasn't that bad when I thought
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the issue:

        https://github.com/apache/struts/pull/120

        All green, if no objections I will merge this PR at the of the day

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/120 All green, if no objections I will merge this PR at the of the day
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/struts/pull/120

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/120
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        PR merged

        Show
        lukaszlenart Lukasz Lenart added a comment - PR merged

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            lukaszlenart Lukasz Lenart
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development