[WW-4744] AnnotationWorkflowInterceptor should supports non-public annotated methods

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.12
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: Yanming Zhou
• Created: 14/Feb/17 01:17
• Updated: 13/Jul/17 19:28
• Resolved: 29/Mar/17 05:23

Description

@Before
protected String prepare(){
    //TODO
    return null;
}

https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java#L115

List<Method> methods = new ArrayList<>(AnnotationUtils.getAnnotatedMethods(action.getClass(), Before.class));

https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java#L123

for (Method m : clazz.getMethods()) 

clazz.getMethods() only return public methods, so method "prepare" will be excluded, and protected modifier is a good practice for intercept method.We should improve AnnotationUtils.getAnnotatedMethods() to return all methods. Perhaps use an ConcurrentHashMap as cache is much better.

Issue Links

• links to: GitHub Pull Request #124
• links to: GitHub Pull Request #144