Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4711

<s:text/> tag should not evaluate defaultMessage against a ValueStack by default

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.5
    • Fix Version/s: 2.5.8
    • Component/s: Core
    • Labels:
      None

      Description

      Right now <s:text/> tag will perform evaluation of a defaultMessage against a ValueStack by default. In most cases the defaultMessage is set to value of name attribute and can be easily used wrong by a developer. Evaluation must be performed only on purpose.

      This change affects also <s:label/> tag and label attribute of all {{UIBean}}s

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #551 (See https://builds.apache.org/job/Struts-JDK7-master/551/)
          WW-4711 Disables searching stack by default (lukaszlenart: rev a5092a24f20d541f4401e66bc1dca79fa86ce020)

          • (edit) core/src/main/java/org/apache/struts2/util/TextProviderHelper.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #551 (See https://builds.apache.org/job/Struts-JDK7-master/551/ ) WW-4711 Disables searching stack by default (lukaszlenart: rev a5092a24f20d541f4401e66bc1dca79fa86ce020) (edit) core/src/main/java/org/apache/struts2/util/TextProviderHelper.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a5092a24f20d541f4401e66bc1dca79fa86ce020 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=a5092a2 ]

          WW-4711 Disables searching stack by default

          Show
          jira-bot ASF subversion and git services added a comment - Commit a5092a24f20d541f4401e66bc1dca79fa86ce020 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=a5092a2 ] WW-4711 Disables searching stack by default
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          I think even searchValueStack attribute should be dropped in a future version

          Show
          lukaszlenart Lukasz Lenart added a comment - I think even searchValueStack attribute should be dropped in a future version
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #548 (See https://builds.apache.org/job/Struts-JDK7-master/548/)
          WW-4711 Disables evaluating ValueStack by default (lukaszlenart: rev 996475d755820914ea4695729ec46159f12625e0)

          • (edit) core/src/test/java/org/apache/struts2/views/jsp/TextTagTest.java
          • (edit) core/src/main/java/org/apache/struts2/components/Text.java
            WW-4711 Disables evaluating ValueStack by default (lukaszlenart: rev 4e7a4b18c0286c34b55529d2db1346df9a7f9dde)
          • (edit) core/src/site/resources/tags/text.html
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #548 (See https://builds.apache.org/job/Struts-JDK7-master/548/ ) WW-4711 Disables evaluating ValueStack by default (lukaszlenart: rev 996475d755820914ea4695729ec46159f12625e0) (edit) core/src/test/java/org/apache/struts2/views/jsp/TextTagTest.java (edit) core/src/main/java/org/apache/struts2/components/Text.java WW-4711 Disables evaluating ValueStack by default (lukaszlenart: rev 4e7a4b18c0286c34b55529d2db1346df9a7f9dde) (edit) core/src/site/resources/tags/text.html
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4e7a4b18c0286c34b55529d2db1346df9a7f9dde in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4e7a4b1 ]

          WW-4711 Disables evaluating ValueStack by default

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4e7a4b18c0286c34b55529d2db1346df9a7f9dde in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4e7a4b1 ] WW-4711 Disables evaluating ValueStack by default
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 996475d755820914ea4695729ec46159f12625e0 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=996475d ]

          WW-4711 Disables evaluating ValueStack by default

          Show
          jira-bot ASF subversion and git services added a comment - Commit 996475d755820914ea4695729ec46159f12625e0 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=996475d ] WW-4711 Disables evaluating ValueStack by default
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          Done

          Show
          lukaszlenart Lukasz Lenart added a comment - Done

            People

            • Assignee:
              Unassigned
              Reporter:
              lukaszlenart Lukasz Lenart
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development