Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4697

Warn about excluded action|method only when DMI is disabled

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.5.5
    • Component/s: Core
    • Labels:
      None

      Description

      Right now ^(action|method):.* are always excluded, even when user is using DMI and in such case it's a proper use case. This pattern must be only applied in case when DMI is disabled.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-JDK7-master #540 (See https://builds.apache.org/job/Struts-JDK7-master/540/)
        WW-4697 If DMI is enabled, exclude action|method params (lukaszlenart: rev 580163880c11af3b0f41538c93af5930ba41ab14)

        • (edit) core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java
          WW-4697 If DMI is sisabled, exclude action|method params (lukaszlenart: rev 5975b7aac7c9fd933aec80d3d3450190f9c2e8fd)
        • (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
        • (edit) core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java
        • (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/MockConfiguration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #540 (See https://builds.apache.org/job/Struts-JDK7-master/540/ ) WW-4697 If DMI is enabled, exclude action|method params (lukaszlenart: rev 580163880c11af3b0f41538c93af5930ba41ab14) (edit) core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java WW-4697 If DMI is sisabled, exclude action|method params (lukaszlenart: rev 5975b7aac7c9fd933aec80d3d3450190f9c2e8fd) (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/MockConfiguration.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5975b7aac7c9fd933aec80d3d3450190f9c2e8fd in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5975b7a ]

        WW-4697 If DMI is sisabled, exclude action|method params

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5975b7aac7c9fd933aec80d3d3450190f9c2e8fd in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5975b7a ] WW-4697 If DMI is sisabled, exclude action|method params
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 580163880c11af3b0f41538c93af5930ba41ab14 in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5801638 ]

        WW-4697 If DMI is enabled, exclude action|method params

        Show
        jira-bot ASF subversion and git services added a comment - Commit 580163880c11af3b0f41538c93af5930ba41ab14 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5801638 ] WW-4697 If DMI is enabled, exclude action|method params

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            lukaszlenart Lukasz Lenart
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development