Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4689

CycleDetector - use enum instead of String constants

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.5
    • Component/s: None
    • Labels:
      None

      Description

      com.opensymphony.xwork2.config.providers.CycleDetector currently uses String constants as values of a HashMap to keep up with the status of the vertexes.

      This could be replaced with an enum.

      see pull request 111 for change suggestion

        Issue Links

          Activity

          Hide
          lukaszlenart Lukasz Lenart added a comment -

          PR merged, thanks!

          Show
          lukaszlenart Lukasz Lenart added a comment - PR merged, thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sdutry commented on the issue:

          https://github.com/apache/struts/pull/111

          registerd jira issue WW-4689(https://issues.apache.org/jira/browse/WW-4689)

          Show
          githubbot ASF GitHub Bot added a comment - Github user sdutry commented on the issue: https://github.com/apache/struts/pull/111 registerd jira issue WW-4689 ( https://issues.apache.org/jira/browse/WW-4689 )

            People

            • Assignee:
              Unassigned
              Reporter:
              sdutry Stefaan Dutry
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development