Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4686

Merge two existing I18NInterceptors into one

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.5
    • Component/s: Core Interceptors
    • Labels:
      None

      Description

      Both existing I18NInterceptor s should be merged into one

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #522 (See https://builds.apache.org/job/Struts-JDK7-master/522/)
          WW-4686 Renames packages in xml (lukaszlenart: rev 7605c1641cc8e7eff1b53ad0c02437d3940cd84a)

          • (edit) core/src/main/resources/xwork-default.xml
          • (edit) core/src/main/resources/struts-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #522 (See https://builds.apache.org/job/Struts-JDK7-master/522/ ) WW-4686 Renames packages in xml (lukaszlenart: rev 7605c1641cc8e7eff1b53ad0c02437d3940cd84a) (edit) core/src/main/resources/xwork-default.xml (edit) core/src/main/resources/struts-default.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #521 (See https://builds.apache.org/job/Struts-JDK7-master/521/)
          WW-4686 Cleans up code and uses Enum (lukaszlenart: rev 41c97636e5de0dc09d258f27404a25d737fbbe23)

          • (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #521 (See https://builds.apache.org/job/Struts-JDK7-master/521/ ) WW-4686 Cleans up code and uses Enum (lukaszlenart: rev 41c97636e5de0dc09d258f27404a25d737fbbe23) (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7605c1641cc8e7eff1b53ad0c02437d3940cd84a in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=7605c16 ]

          WW-4686 Renames packages in xml

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7605c1641cc8e7eff1b53ad0c02437d3940cd84a in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=7605c16 ] WW-4686 Renames packages in xml
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          Aleksandr Mashchenko you were right, this is already implemented. Just don't define struts.locale and Dispatcher will use locale provided by browser.

          Show
          lukaszlenart Lukasz Lenart added a comment - Aleksandr Mashchenko you were right, this is already implemented. Just don't define struts.locale and Dispatcher will use locale provided by browser.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #520 (See https://builds.apache.org/job/Struts-JDK7-master/520/)
          WW-4686 Merges two implementations of I18N interceptor (lukaszlenart: rev 07bb62ba8f661aaf1f5d5f874408dcdf6c00a0a2)

          • (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java
          • (delete) core/src/main/java/com/opensymphony/xwork2/interceptor/I18nInterceptor.java
          • (delete) core/src/test/java/com/opensymphony/xwork2/interceptor/I18nInterceptorTest.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #520 (See https://builds.apache.org/job/Struts-JDK7-master/520/ ) WW-4686 Merges two implementations of I18N interceptor (lukaszlenart: rev 07bb62ba8f661aaf1f5d5f874408dcdf6c00a0a2) (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java (delete) core/src/main/java/com/opensymphony/xwork2/interceptor/I18nInterceptor.java (delete) core/src/test/java/com/opensymphony/xwork2/interceptor/I18nInterceptorTest.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 41c97636e5de0dc09d258f27404a25d737fbbe23 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=41c9763 ]

          WW-4686 Cleans up code and uses Enum

          Show
          jira-bot ASF subversion and git services added a comment - Commit 41c97636e5de0dc09d258f27404a25d737fbbe23 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=41c9763 ] WW-4686 Cleans up code and uses Enum
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 07bb62ba8f661aaf1f5d5f874408dcdf6c00a0a2 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=07bb62b ]

          WW-4686 Merges two implementations of I18N interceptor

          Show
          jira-bot ASF subversion and git services added a comment - Commit 07bb62ba8f661aaf1f5d5f874408dcdf6c00a0a2 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=07bb62b ] WW-4686 Merges two implementations of I18N interceptor
          Hide
          lukaszlenart Lukasz Lenart added a comment - - edited

          But this is something application wide and not related to current user language settings. So I treat this as an application default locale which means if I set struts.locale to DE, the package.properties containes German transalation even if server is running on EN locale. Does it make sense?

          Show
          lukaszlenart Lukasz Lenart added a comment - - edited But this is something application wide and not related to current user language settings. So I treat this as an application default locale which means if I set struts.locale to DE , the package.properties containes German transalation even if server is running on EN locale. Does it make sense?
          Show
          aleksandr-m Aleksandr Mashchenko added a comment - What about struts.locale defined in struts.xml? https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java#L235

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              lukaszlenart Lukasz Lenart
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development