[WW-4618] MessageStorePreResultListener doesn't store messages for 3rd-party RedirectResult subclasses

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.28
• Fix Version/s: 2.3.29, 2.5.1
• Assignee: Lukasz Lenart
• Reporter: Jim deVos
• Created: 24/Mar/16 18:33
• Updated: 23/Jun/16 10:56
• Resolved: 13/May/16 05:06

Description

My team uses a custom subclass of ServletRedirectResult, e.g. "org.tdar.struts.ServletRedirectResult". After updating to 2.3.8 our messages no longer survive a redirect. I believe the problem lies with this section of MessageStorePreResultListener:

if (resultConfig != null) {
    isRedirect = ServletRedirectResult.class.getName().equals(resultConfig.getClassName())
            || ServletActionRedirectResult.class.getName().equals(resultConfig.getClassName());
}

Per the discussion in WW-4605, the following change could likely resolve the issue:

if (resultConfig != null) {
    isRedirect = ServletRedirectResult.class.isAssignableFrom(Class.forName(resultConfig.getClassName()));
}

Issue Links

• relates to: WW-4605 Refactor MessageStoreInterceptor and use PreResultListener to store messages