Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4584

Upgrade Tiles 3 pugin to latest available Tiles 3 version

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: Plugin - Tiles
    • Labels:
      None

      Activity

      Hide
      githubbot ASF GitHub Bot added a comment -

      GitHub user lukaszlenart opened a pull request:

      https://github.com/apache/struts/pull/73

      WW-4584: Upgrade tiles plugin

      WW-4584(https://issues.apache.org/jira/browse/WW-4584) Upgrades Tiles plugin to use Tiles 3 version, it also drops Tiles 3 plugin - there will be only one plugin to support Tiles 3

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/lukaszlenart/struts upgrade-tiles-plugin

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/struts/pull/73.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #73


      commit 85b219813f982ad28059197c6ebcb0b099f7e4b3
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:22:31Z

      Adds required dependencies

      commit 70716e945295526d207cab6c66306a3113f8a333
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:18Z

      Re-implements tiles integration based on new API

      commit 24a5bce6c436ddaea9f65f792b280fdd6f9c4ae3
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:24Z

      Drops unused classes

      commit 26f153d262f7a4dfb767c391afece8ac1d9e1c0d
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:43Z

      Replaces call to deprecated api

      commit 6edc0ff5e0410651f7055654116c3346aeaa4ee5
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:37:42Z

      Updates Portal Tiles integration

      commit 27ad6cb13e9fa75d48f8e5cf26687b49af9ed213
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:54:39Z

      Adds missing header with license

      commit 388861ff073f54f7959a35cc205b264237d043d0
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-27T12:36:52Z

      Registers Tiles model

      commit 6622fab25bee1dae9085cca56b87711f3197916d
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-27T15:09:37Z

      Fixes dependency clash

      commit 2d0fe9f742c9add4a1803d3165a3ed906551dc45
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T07:19:26Z

      Drops Tiles 3 plugin

      commit 5fe760dc67f4b3bd16112ac48494782e570dd242
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T07:19:52Z

      Removes module

      commit 47ecd001ec8b35e4569d43a481e82166eed6cfb1
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T07:51:03Z

      Ports solution from 2.3.x branch

      commit af82d23c95f592bac84f1cac105bc00163c53b4d
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T07:51:14Z

      Upgrade Tiles dependencies

      commit b675844a8f0de848d200439ed01ebbb532ca9b53
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T07:51:34Z

      Ports solution to resolve problem with EL functions

      commit 4638b3345757b900edead4a5e4de4c3d37c0eafe
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T09:13:38Z

      Adds missing Tiles API dependency

      commit ace6a5d5ee0bdcfc81225832a477dff1bf4effbf
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T09:13:51Z

      Adjusts code to Tiles 3

      commit c07020cb7cc1d1a8eb15cacc7f62be3a864474f8
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T09:14:11Z

      Uses new way to access TileContainer

      commit 33edfffbe256e071fc33355518f24457da815a8b
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2016-01-12T09:36:46Z

      Migrates tiles-portlet to the same version


      Show
      githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/73 WW-4584 : Upgrade tiles plugin WW-4584 ( https://issues.apache.org/jira/browse/WW-4584 ) Upgrades Tiles plugin to use Tiles 3 version, it also drops Tiles 3 plugin - there will be only one plugin to support Tiles 3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts upgrade-tiles-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 85b219813f982ad28059197c6ebcb0b099f7e4b3 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:22:31Z Adds required dependencies commit 70716e945295526d207cab6c66306a3113f8a333 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:18Z Re-implements tiles integration based on new API commit 24a5bce6c436ddaea9f65f792b280fdd6f9c4ae3 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:24Z Drops unused classes commit 26f153d262f7a4dfb767c391afece8ac1d9e1c0d Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:43Z Replaces call to deprecated api commit 6edc0ff5e0410651f7055654116c3346aeaa4ee5 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:37:42Z Updates Portal Tiles integration commit 27ad6cb13e9fa75d48f8e5cf26687b49af9ed213 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:54:39Z Adds missing header with license commit 388861ff073f54f7959a35cc205b264237d043d0 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-27T12:36:52Z Registers Tiles model commit 6622fab25bee1dae9085cca56b87711f3197916d Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-27T15:09:37Z Fixes dependency clash commit 2d0fe9f742c9add4a1803d3165a3ed906551dc45 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T07:19:26Z Drops Tiles 3 plugin commit 5fe760dc67f4b3bd16112ac48494782e570dd242 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T07:19:52Z Removes module commit 47ecd001ec8b35e4569d43a481e82166eed6cfb1 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T07:51:03Z Ports solution from 2.3.x branch commit af82d23c95f592bac84f1cac105bc00163c53b4d Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T07:51:14Z Upgrade Tiles dependencies commit b675844a8f0de848d200439ed01ebbb532ca9b53 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T07:51:34Z Ports solution to resolve problem with EL functions commit 4638b3345757b900edead4a5e4de4c3d37c0eafe Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T09:13:38Z Adds missing Tiles API dependency commit ace6a5d5ee0bdcfc81225832a477dff1bf4effbf Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T09:13:51Z Adjusts code to Tiles 3 commit c07020cb7cc1d1a8eb15cacc7f62be3a864474f8 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T09:14:11Z Uses new way to access TileContainer commit 33edfffbe256e071fc33355518f24457da815a8b Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2016-01-12T09:36:46Z Migrates tiles-portlet to the same version
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user cnenning commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-170932000

      :+1:
      Looks great!

      There is one thing: when I try to run showcase app I get exceptions when trying to access tiles examples: `org.apache.tiles.definition.NoSuchDefinitionException: Cannot find definition named 'showcase.index'`

      The definition is defined in `showcase/src/main/webapp/WEB-INF/tiles.xml`. When I try to copy that file to different locations (like `webapp/` or `src/main/resources/`) the error remains.

      IMO that can be solved in `master`.

      Show
      githubbot ASF GitHub Bot added a comment - Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-170932000 :+1: Looks great! There is one thing: when I try to run showcase app I get exceptions when trying to access tiles examples: `org.apache.tiles.definition.NoSuchDefinitionException: Cannot find definition named 'showcase.index'` The definition is defined in `showcase/src/main/webapp/WEB-INF/tiles.xml`. When I try to copy that file to different locations (like `webapp/` or `src/main/resources/`) the error remains. IMO that can be solved in `master`.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-170938090

      I just ported the solution from `support-2-3` branch and adjusted API, didn't test it yet but will do it later today, tomorrow. I hope it's be an easy fix

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-170938090 I just ported the solution from `support-2-3` branch and adjusted API, didn't test it yet but will do it later today, tomorrow. I hope it's be an easy fix
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user aleksandr-m commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171035814

      Same thing here. Getting `NoSuchDefinitionException` exception in my app when trying to use tiles result.

      Note: there is still reference to tiles3-plugin in bom pom.xml.

      Show
      githubbot ASF GitHub Bot added a comment - Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171035814 Same thing here. Getting `NoSuchDefinitionException` exception in my app when trying to use tiles result. Note: there is still reference to tiles3-plugin in bom pom.xml.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171055589

      Thanks, I found the reason, now working on solution

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171055589 Thanks, I found the reason, now working on solution
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171256054

      I have resolved the problem with missing definitions but I'm a bit confused how Tiles resolves resources - 66d29d4 - basically all the definitions are loaded on startup but then are loaded again.

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171256054 I have resolved the problem with missing definitions but I'm a bit confused how Tiles resolves resources - 66d29d4 - basically all the definitions are loaded on startup but then are loaded again.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user aleksandr-m commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171590254

      :+1:
      It works.
      Thank you for your great work.

      Show
      githubbot ASF GitHub Bot added a comment - Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171590254 :+1: It works. Thank you for your great work.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user cnenning commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171662399

      > I have resolved the problem with missing definitions but I'm a bit confused how Tiles resolves
      > resources - 66d29d4 - basically all the definitions are loaded on startup but then are loaded again.

      In my experiments the tiles.xml was only loaded one time, at first request.

      Show
      githubbot ASF GitHub Bot added a comment - Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171662399 > I have resolved the problem with missing definitions but I'm a bit confused how Tiles resolves > resources - 66d29d4 - basically all the definitions are loaded on startup but then are loaded again. In my experiments the tiles.xml was only loaded one time, at first request.
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171891083

      > In my experiments the tiles.xml was only loaded one time, at first request.

      Yes, it was clarified during my discussion on Tiles Users mailing list

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171891083 > In my experiments the tiles.xml was only loaded one time, at first request. Yes, it was clarified during my discussion on Tiles Users mailing list
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171909190

      I think the solution is final, I have added support for Struts' Locale and properly implemented support for it. I also updated `struts-examples`. Enjoy!

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171909190 I think the solution is final, I have added support for Struts' Locale and properly implemented support for it. I also updated `struts-examples`. Enjoy!
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user cnenning commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-171968504

      :+1:

      Show
      githubbot ASF GitHub Bot added a comment - Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171968504 :+1:
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user cnenning commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-172460318

      > Simplifies logging

      Still not final :wink: ?

      Let's merge it!

      Show
      githubbot ASF GitHub Bot added a comment - Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-172460318 > Simplifies logging Still not final :wink: ? Let's merge it!
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart commented on the pull request:

      https://github.com/apache/struts/pull/73#issuecomment-172462730

      I have got some comments on my questions sent to Tiles Users mailing list and the current implementation isn't optimal But I have no better idea so let's merge it

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-172462730 I have got some comments on my questions sent to Tiles Users mailing list and the current implementation isn't optimal But I have no better idea so let's merge it
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit d923c7c4f2c7a674949c623350cd8948869ea987 in struts's branch refs/heads/master from Lukasz Lenart
      [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d923c7c ]

      WW-4584 Upgrades Tiles plugin to Tiles 3
      Also drops existing Tiles 3 plugin

      Show
      jira-bot ASF subversion and git services added a comment - Commit d923c7c4f2c7a674949c623350cd8948869ea987 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d923c7c ] WW-4584 Upgrades Tiles plugin to Tiles 3 Also drops existing Tiles 3 plugin
      Hide
      lukaszlenart Lukasz Lenart added a comment -

      PR merged

      Show
      lukaszlenart Lukasz Lenart added a comment - PR merged
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user asfgit closed the pull request at:

      https://github.com/apache/struts/pull/73

      Show
      githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/73

        People

        • Assignee:
          Unassigned
          Reporter:
          lukaszlenart Lukasz Lenart
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development