Struts 2
  1. Struts 2
  2. WW-4572

Add dedicated class to represent Http Parameters

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.24
    • Fix Version/s: 2.5.5
    • Component/s: "New" API
    • Labels:
      None

      Description

      Right now parameters are represented by a Map and a lot of logic is duplicated. There is no way to check if given parameter was already evaluated.

        Issue Links

          Activity

          Hide
          Lukasz Lenart added a comment -
          Show
          Lukasz Lenart added a comment - PR is ready https://github.com/apache/struts/pull/58
          Hide
          ASF GitHub Bot added a comment -

          Github user ke4qqq closed the pull request at:

          https://github.com/apache/struts/pull/58

          Show
          ASF GitHub Bot added a comment - Github user ke4qqq closed the pull request at: https://github.com/apache/struts/pull/58
          Hide
          ASF GitHub Bot added a comment -

          GitHub user lukaszlenart reopened a pull request:

          https://github.com/apache/struts/pull/58

          Http parameters

          Implements WW-4572

          This PR converts `parameters` to be represented by a dedicated class - `HttpParameters` - instead of using a simple `Map`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lukaszlenart/struts http-parameters

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/struts/pull/58.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #58


          commit 6b20fb51ba18d82e06b791094aa52fe135e4825a
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T07:29:11Z

          Introduces new class to represent HTTP parameters

          commit 787f2f96eb9f1bb3c8012ab42aa222ae6286a91a
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T07:30:03Z

          Introduces new class to represent expression evaluation

          commit 330a0edf264328e01792ffd911957aa3547a0ae0
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T07:30:23Z

          Uses the class instead of a Map

          commit 5508352ddb46417ccd44033064ea337da509c021
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T07:32:10Z

          Uses HttpParameters class instead of a generic Map

          commit 6ad4f9f0184fa1aaf411742c4e753bb3aa66394c
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T09:14:27Z

          Updates implementation and fixes test

          commit 26235599cd6fc5f9519c268cc6861d52a0d99652
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:04:40Z

          Fixes issue with filtering out excluded params

          commit 8282d60fa53b6df3fd68704cbdb25192650fd4a2
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:09:28Z

          Adjusts test

          commit fe1cbc453af86cddf89b9c792f0b6814f4549243
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:12:17Z

          Updates test

          commit c393a428bee66ef7c8b12320a3d69251263d10c1
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:27:55Z

          Fixes test and cleans up naming

          commit 2c110e2a461dc2acfeede416df0182940d3c3b49
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:29:46Z

          Fixes test

          commit fcd407cb451253980977b21f1c05120596d6d469
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:30:32Z

          Fixes test

          commit b0a2fbcc077664db6b788aacbad3538429c6f972
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:32:41Z

          Fixes test

          commit 560f03025f142fa4bbcf0a5bc83c5b798d9c9229
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:33:25Z

          Fixes test

          commit b373d6a43a9d40e4802eea721fe792af3ec59d40
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:33:59Z

          Fixes test

          commit 1fa8eac8bd3d36a32bc582e3ca9a79d184f3efe3
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:34:30Z

          Fixes test

          commit 4b8f7b06802c9328eb18c5e0da4e9682416744f9
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:35:01Z

          Fixes test

          commit 6fd94e86617aafe08afcad487b9179b03a629ec4
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:36:44Z

          Fixes test

          commit bda06c8baa2f65b6e340a7a8bc24a635a865bbcd
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:38:02Z

          Fixes test

          commit 8dc6f77e0ba22ee9f7667488e4051aa40d0a0642
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T12:52:33Z

          Creates ActionMapping with empty params

          commit bb115bef81cda211e07c7ce77a5187fe112c3f3e
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T13:39:22Z

          Fixes support for checkboxes

          commit 48602b899d03d953782244858dc8c521b8287b73
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T18:40:29Z

          Fixes test

          commit c14791a2a05072626462f62518bf28d468b3af46
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T18:49:14Z

          Fixes test

          commit 582bb32e4bc982830bd75d3a125c635c48db2d85
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T18:56:19Z

          Adjusts interceptor

          commit 9640c2b3a14ad1c0426cdcb4c469672eba6bc414
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T19:10:19Z

          Fixes test

          commit bb096d6415c4750c5a08aa35605e789e880a9a14
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-05T19:11:27Z

          Fixes test

          commit 3a0bd4caf047dfe2918bc4527ffa41f2342b947e
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-10-06T06:02:30Z

          Updates tests

          commit ce8ac8e3ce0070bd1a73c1202719e26e48800523
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-11-25T18:02:54Z

          Introduces getObject getter to keep compatibility

          commit 60b9d85d44826f7421ddaaa5870a7818e7f5fb41
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-11-25T18:03:30Z

          Adjusts usage of parameters

          commit 059ebc72c2e58bb96e586bda797e55ed43a806c9
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-11-25T18:03:36Z

          Updates tests

          commit 278b22a0b4661f67d461675c3ac51d55856fb9b5
          Author: Lukasz Lenart <lukasz.lenart@gmail.com>
          Date: 2015-12-19T11:07:22Z

          Renames method to better express its meaning


          Show
          ASF GitHub Bot added a comment - GitHub user lukaszlenart reopened a pull request: https://github.com/apache/struts/pull/58 Http parameters Implements WW-4572 This PR converts `parameters` to be represented by a dedicated class - `HttpParameters` - instead of using a simple `Map`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts http-parameters Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 6b20fb51ba18d82e06b791094aa52fe135e4825a Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T07:29:11Z Introduces new class to represent HTTP parameters commit 787f2f96eb9f1bb3c8012ab42aa222ae6286a91a Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T07:30:03Z Introduces new class to represent expression evaluation commit 330a0edf264328e01792ffd911957aa3547a0ae0 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T07:30:23Z Uses the class instead of a Map commit 5508352ddb46417ccd44033064ea337da509c021 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T07:32:10Z Uses HttpParameters class instead of a generic Map commit 6ad4f9f0184fa1aaf411742c4e753bb3aa66394c Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T09:14:27Z Updates implementation and fixes test commit 26235599cd6fc5f9519c268cc6861d52a0d99652 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:04:40Z Fixes issue with filtering out excluded params commit 8282d60fa53b6df3fd68704cbdb25192650fd4a2 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:09:28Z Adjusts test commit fe1cbc453af86cddf89b9c792f0b6814f4549243 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:12:17Z Updates test commit c393a428bee66ef7c8b12320a3d69251263d10c1 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:27:55Z Fixes test and cleans up naming commit 2c110e2a461dc2acfeede416df0182940d3c3b49 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:29:46Z Fixes test commit fcd407cb451253980977b21f1c05120596d6d469 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:30:32Z Fixes test commit b0a2fbcc077664db6b788aacbad3538429c6f972 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:32:41Z Fixes test commit 560f03025f142fa4bbcf0a5bc83c5b798d9c9229 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:33:25Z Fixes test commit b373d6a43a9d40e4802eea721fe792af3ec59d40 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:33:59Z Fixes test commit 1fa8eac8bd3d36a32bc582e3ca9a79d184f3efe3 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:34:30Z Fixes test commit 4b8f7b06802c9328eb18c5e0da4e9682416744f9 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:35:01Z Fixes test commit 6fd94e86617aafe08afcad487b9179b03a629ec4 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:36:44Z Fixes test commit bda06c8baa2f65b6e340a7a8bc24a635a865bbcd Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:38:02Z Fixes test commit 8dc6f77e0ba22ee9f7667488e4051aa40d0a0642 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T12:52:33Z Creates ActionMapping with empty params commit bb115bef81cda211e07c7ce77a5187fe112c3f3e Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T13:39:22Z Fixes support for checkboxes commit 48602b899d03d953782244858dc8c521b8287b73 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T18:40:29Z Fixes test commit c14791a2a05072626462f62518bf28d468b3af46 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T18:49:14Z Fixes test commit 582bb32e4bc982830bd75d3a125c635c48db2d85 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T18:56:19Z Adjusts interceptor commit 9640c2b3a14ad1c0426cdcb4c469672eba6bc414 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T19:10:19Z Fixes test commit bb096d6415c4750c5a08aa35605e789e880a9a14 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-05T19:11:27Z Fixes test commit 3a0bd4caf047dfe2918bc4527ffa41f2342b947e Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-10-06T06:02:30Z Updates tests commit ce8ac8e3ce0070bd1a73c1202719e26e48800523 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T18:02:54Z Introduces getObject getter to keep compatibility commit 60b9d85d44826f7421ddaaa5870a7818e7f5fb41 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T18:03:30Z Adjusts usage of parameters commit 059ebc72c2e58bb96e586bda797e55ed43a806c9 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T18:03:36Z Updates tests commit 278b22a0b4661f67d461675c3ac51d55856fb9b5 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-12-19T11:07:22Z Renames method to better express its meaning
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/struts/pull/58

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/58
          Hide
          Lukasz Lenart added a comment -

          Party time!!! PR merged!

          Show
          Lukasz Lenart added a comment - Party time!!! PR merged!
          Hide
          ASF subversion and git services added a comment -

          Commit bb403720acb559ba10e372511dc6caaeda724c3b in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb40372 ]

          WW-4572 Reverts ParameterAware interface to its previous version and introduces new one

          Show
          ASF subversion and git services added a comment - Commit bb403720acb559ba10e372511dc6caaeda724c3b in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb40372 ] WW-4572 Reverts ParameterAware interface to its previous version and introduces new one
          Hide
          ASF subversion and git services added a comment -

          Commit adeda4788b65f093b496551e2b32ad0218087a20 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=adeda47 ]

          WW-4572 Updates JavaDocs

          Show
          ASF subversion and git services added a comment - Commit adeda4788b65f093b496551e2b32ad0218087a20 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=adeda47 ] WW-4572 Updates JavaDocs
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Jenkins build Struts-JDK7-master #536 (See https://builds.apache.org/job/Struts-JDK7-master/536/)
          WW-4572 Reverts ParameterAware interface to its previous version and (lukaszlenart: rev bb403720acb559ba10e372511dc6caaeda724c3b)

          • (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java
          • (add) core/src/main/java/org/apache/struts2/interceptor/HttpParametersAware.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
            WW-4572 Updates JavaDocs (lukaszlenart: rev adeda4788b65f093b496551e2b32ad0218087a20)
          • (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
          Show
          Hudson added a comment - FAILURE: Integrated in Jenkins build Struts-JDK7-master #536 (See https://builds.apache.org/job/Struts-JDK7-master/536/ ) WW-4572 Reverts ParameterAware interface to its previous version and (lukaszlenart: rev bb403720acb559ba10e372511dc6caaeda724c3b) (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java (add) core/src/main/java/org/apache/struts2/interceptor/HttpParametersAware.java (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java (edit) core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java WW-4572 Updates JavaDocs (lukaszlenart: rev adeda4788b65f093b496551e2b32ad0218087a20) (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java
          Hide
          ASF subversion and git services added a comment -

          Commit 69da41eb793ad31a6c076e109dbfa6dd1b5a1cd5 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=69da41e ]

          WW-4572 Fixes issue with file upload

          Show
          ASF subversion and git services added a comment - Commit 69da41eb793ad31a6c076e109dbfa6dd1b5a1cd5 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=69da41e ] WW-4572 Fixes issue with file upload
          Hide
          ASF subversion and git services added a comment -

          Commit 6ab6ec879cc9eb1997b88856173d2123b32509ee in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6ab6ec8 ]

          WW-4572 Simplifies method name

          Show
          ASF subversion and git services added a comment - Commit 6ab6ec879cc9eb1997b88856173d2123b32509ee in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6ab6ec8 ] WW-4572 Simplifies method name
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #538 (See https://builds.apache.org/job/Struts-JDK7-master/538/)
          WW-4572 Fixes issue with file upload (lukaszlenart: rev 69da41eb793ad31a6c076e109dbfa6dd1b5a1cd5)

          • (edit) plugins/embeddedjsp/src/main/java/org/apache/struts2/JSPRuntime.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/MultiselectInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/DateTextFieldInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/CheckboxInterceptor.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/dispatcher/Parameter.java
            WW-4572 Simplifies method name (lukaszlenart: rev 6ab6ec879cc9eb1997b88856173d2123b32509ee)
          • (edit) core/src/test/java/org/apache/struts2/interceptor/TokenInterceptorTest.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/FileUploadInterceptorTest.java
          • (edit) core/src/test/java/com/opensymphony/xwork2/validator/DoubleRangeValidatorTest.java
          • (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/result/PortletResultTest.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/MessageStoreInterceptorTest.java
          • (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java
          • (edit) core/src/test/java/org/apache/struts2/util/TokenHelperTest.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java
          • (edit) core/src/test/java/com/opensymphony/xwork2/validator/ValidatorAnnotationTest.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java
          • (edit) core/src/test/java/com/opensymphony/xwork2/ActionContextTest.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/MessageStorePreResultListenerTest.java
          • (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/StaticParametersInterceptor.java
          • (edit) core/src/main/java/org/apache/struts2/components/ActionComponent.java
          • (edit) core/src/main/java/org/apache/struts2/interceptor/ActionMappingParametersInteceptor.java
          • (edit) core/src/test/java/com/opensymphony/xwork2/interceptor/StaticParametersInterceptorTest.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #538 (See https://builds.apache.org/job/Struts-JDK7-master/538/ ) WW-4572 Fixes issue with file upload (lukaszlenart: rev 69da41eb793ad31a6c076e109dbfa6dd1b5a1cd5) (edit) plugins/embeddedjsp/src/main/java/org/apache/struts2/JSPRuntime.java (edit) core/src/main/java/org/apache/struts2/interceptor/MultiselectInterceptor.java (edit) core/src/main/java/org/apache/struts2/interceptor/DateTextFieldInterceptor.java (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java (edit) core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java (edit) core/src/main/java/org/apache/struts2/interceptor/CheckboxInterceptor.java (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java (edit) core/src/main/java/org/apache/struts2/dispatcher/Parameter.java WW-4572 Simplifies method name (lukaszlenart: rev 6ab6ec879cc9eb1997b88856173d2123b32509ee) (edit) core/src/test/java/org/apache/struts2/interceptor/TokenInterceptorTest.java (edit) core/src/test/java/org/apache/struts2/interceptor/FileUploadInterceptorTest.java (edit) core/src/test/java/com/opensymphony/xwork2/validator/DoubleRangeValidatorTest.java (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/result/PortletResultTest.java (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java (edit) core/src/test/java/org/apache/struts2/interceptor/MessageStoreInterceptorTest.java (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java (edit) core/src/test/java/org/apache/struts2/util/TokenHelperTest.java (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java (edit) core/src/test/java/com/opensymphony/xwork2/validator/ValidatorAnnotationTest.java (edit) core/src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java (edit) core/src/test/java/com/opensymphony/xwork2/ActionContextTest.java (edit) core/src/test/java/org/apache/struts2/interceptor/MessageStorePreResultListenerTest.java (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/StaticParametersInterceptor.java (edit) core/src/main/java/org/apache/struts2/components/ActionComponent.java (edit) core/src/main/java/org/apache/struts2/interceptor/ActionMappingParametersInteceptor.java (edit) core/src/test/java/com/opensymphony/xwork2/interceptor/StaticParametersInterceptorTest.java
          Hide
          Glen Mazza added a comment - - edited

          This change appears to break backwards compatibility, upon upgrade from Struts 2.5.2 to 2.5.5 the following code no longer worked:

              <s:property value='%{#parameters.weblogId}'/>   // returns empty string.
          

          Apparent solution (haven't tested yet) is here: http://stackoverflow.com/a/40365187/1207540

          Show
          Glen Mazza added a comment - - edited This change appears to break backwards compatibility, upon upgrade from Struts 2.5.2 to 2.5.5 the following code no longer worked: <s:property value='%{#parameters.weblogId}'/> // returns empty string. Apparent solution (haven't tested yet) is here: http://stackoverflow.com/a/40365187/1207540

            People

            • Assignee:
              Lukasz Lenart
              Reporter:
              Lukasz Lenart
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development