Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: Build Management
    • Labels:
      None

      Description

      Switch to JDK 7 to take advantage of new syntax such as try-with-resources.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
          WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a)
        • pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a) pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Struts-JDK7-pull-request #37 (See https://builds.apache.org/job/Struts-JDK7-pull-request/37/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
          WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a)
        • pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Struts-JDK7-pull-request #37 (See https://builds.apache.org/job/Struts-JDK7-pull-request/37/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a) pom.xml
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Struts-JDK7-master #317 (See https://builds.apache.org/job/Struts-JDK7-master/317/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-master #317 (See https://builds.apache.org/job/Struts-JDK7-master/317/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-pull-request #35 (See https://builds.apache.org/job/Struts-JDK7-pull-request/35/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-pull-request #35 (See https://builds.apache.org/job/Struts-JDK7-pull-request/35/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Struts-JDK7-master #301 (See https://builds.apache.org/job/Struts-JDK7-master/301/)
        WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a)

        • pom.xml
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Struts-JDK7-master #301 (See https://builds.apache.org/job/Struts-JDK7-master/301/ ) WW-4503 Sitches to JDK7 (lukaszlenart: rev 25cdfd62e3a4a4625863492c64b843f780354d2a) pom.xml
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Patch applied, thanks!

        Show
        lukaszlenart Lukasz Lenart added a comment - Patch applied, thanks!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 25cdfd62e3a4a4625863492c64b843f780354d2a in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=25cdfd6 ]

        WW-4503 Sitches to JDK7

        Show
        jira-bot ASF subversion and git services added a comment - Commit 25cdfd62e3a4a4625863492c64b843f780354d2a in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=25cdfd6 ] WW-4503 Sitches to JDK7
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-106001352

        Ok, I will handle this based on your work, thanks! It will take some time as releasing new version of struts-annotations requires a vote

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-106001352 Ok, I will handle this based on your work, thanks! It will take some time as releasing new version of struts-annotations requires a vote
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user swiftelan commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105947844

        Moving to Java 7 requires the new annotation parser or the removal of the maven-apt-plugin. The annotation parser [job](https://builds.apache.org/view/S-Z/view/Struts/job/struts-annotations/) is disabled. Using a snapshot version of the annotation processor will fail the build. It might be easier for you to coordinate changes to both repositories.

        Show
        githubbot ASF GitHub Bot added a comment - Github user swiftelan commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105947844 Moving to Java 7 requires the new annotation parser or the removal of the maven-apt-plugin. The annotation parser [job] ( https://builds.apache.org/view/S-Z/view/Struts/job/struts-annotations/ ) is disabled. Using a snapshot version of the annotation processor will fail the build. It might be easier for you to coordinate changes to both repositories.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105880104

        Are you going to open a new PR to introduce JDK7? If not I can do it directly based on your changes - it's an easy fix

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105880104 Are you going to open a new PR to introduce JDK7? If not I can do it directly based on your changes - it's an easy fix
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105879836

        Yeah... each change must be in separated branch and every commit to that branch will be automatically exposed as a part of PR. That's how it works

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105879836 Yeah... each change must be in separated branch and every commit to that branch will be automatically exposed as a part of PR. That's how it works
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user swiftelan closed the pull request at:

        https://github.com/apache/struts/pull/39

        Show
        githubbot ASF GitHub Bot added a comment - Github user swiftelan closed the pull request at: https://github.com/apache/struts/pull/39
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user swiftelan commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105621794

        I understand. I merged changes from the GitHub mirror to my fork. I didn't know that it would update the existing pull request, that was not my intention.

        Show
        githubbot ASF GitHub Bot added a comment - Github user swiftelan commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105621794 I understand. I merged changes from the GitHub mirror to my fork. I didn't know that it would update the existing pull request, that was not my intention.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105598273

        This PRs mixed fixes for two different things

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105598273 This PRs mixed fixes for two different things
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on a diff in the pull request:

        https://github.com/apache/struts/pull/39#discussion_r31053051

        — Diff: pom.xml —
        @@ -352,7 +353,7 @@
        <dependency>
        <groupId>org.apache.struts</groupId>
        <artifactId>struts-annotations</artifactId>

        • <version>1.0.5</version>
          + <version>1.0.6-SNAPSHOT</version>
            • End diff –

        Now I get it, we must first update struts-annotations project, release it and then we can use it here

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/39#discussion_r31053051 — Diff: pom.xml — @@ -352,7 +353,7 @@ <dependency> <groupId>org.apache.struts</groupId> <artifactId>struts-annotations</artifactId> <version>1.0.5</version> + <version>1.0.6-SNAPSHOT</version> End diff – Now I get it, we must first update struts-annotations project, release it and then we can use it here
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on the pull request:

        https://github.com/apache/struts/pull/39#issuecomment-105588791

        It's better to use two dedicated PRs where each addresses just one issue.

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/39#issuecomment-105588791 It's better to use two dedicated PRs where each addresses just one issue.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on a diff in the pull request:

        https://github.com/apache/struts/pull/39#discussion_r31052042

        — Diff: pom.xml —
        @@ -352,7 +353,7 @@
        <dependency>
        <groupId>org.apache.struts</groupId>
        <artifactId>struts-annotations</artifactId>

        • <version>1.0.5</version>
          + <version>1.0.6-SNAPSHOT</version>
            • End diff –

        Do we need this? I thought after dropping APT we can drop this as well

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/39#discussion_r31052042 — Diff: pom.xml — @@ -352,7 +353,7 @@ <dependency> <groupId>org.apache.struts</groupId> <artifactId>struts-annotations</artifactId> <version>1.0.5</version> + <version>1.0.6-SNAPSHOT</version> End diff – Do we need this? I thought after dropping APT we can drop this as well
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Struts-JDK7-pull-request #29 (See https://builds.apache.org/job/Struts-JDK7-pull-request/29/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Struts-JDK7-pull-request #29 (See https://builds.apache.org/job/Struts-JDK7-pull-request/29/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Struts-JDK7-pull-request #28 (See https://builds.apache.org/job/Struts-JDK7-pull-request/28/)
        WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b)

        • pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Struts-JDK7-pull-request #28 (See https://builds.apache.org/job/Struts-JDK7-pull-request/28/ ) WW-4503 Build Struts with JDK 7 (aaron.johnson: rev e262854e2a1b7548efa0a1eb50d350ecd215231b) pom.xml
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user swiftelan opened a pull request:

        https://github.com/apache/struts/pull/39

        WW-4503 Build Struts with JDK 7

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/swiftelan/struts master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/39.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #39


        commit e262854e2a1b7548efa0a1eb50d350ecd215231b
        Author: Aaron Johnson <aaron.johnson@pearson.com>
        Date: 2015-05-22T14:28:08Z

        WW-4503 Build Struts with JDK 7


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user swiftelan opened a pull request: https://github.com/apache/struts/pull/39 WW-4503 Build Struts with JDK 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/swiftelan/struts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit e262854e2a1b7548efa0a1eb50d350ecd215231b Author: Aaron Johnson <aaron.johnson@pearson.com> Date: 2015-05-22T14:28:08Z WW-4503 Build Struts with JDK 7

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            swiftelan Aaron Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development