[WW-4488] Improve performance of DefaultExcludedPatternsChecker

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3.20
• Fix Version/s: 2.3.24
• Component/s: Core Interceptors
• Assignee: Lukasz Lenart
• Reporter: Jasper Rosenberg
• Created: 09/Apr/15 11:37
• Updated: 30/Nov/15 14:47
• Resolved: 29/Apr/15 19:46

Description

The current set of patterns can be consolidated without sacrificing readability for a significant gain in efficiency. I ran both sets of equivalent patterns against the three test methods in DefaultExcludedPatternsCheckerTest 100,000 times, and the consolidated pattern was 3 times faster.

    public static final String[] EXCLUDED_PATTERNS = {
        "(.*\\.|^|.*|\\[('|\"))\\bclass(\\.|('|\")]|\\[).*",
        "(^|.*#)(dojo|struts|session|request|application|servlet(Request|Response)"
         + "|parameters|context|_memberAccess)(\\.|\\[).*"
    };