[WW-4482] Conversion annotation ignored for ServletAction parameter

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.3.20
• Fix Version/s: 2.3.24
• Component/s: Expression Language, Value Stack
• Assignee: Lukasz Lenart
• Reporter: Jasper Rosenberg
• Created: 21/Mar/15 12:12
• Updated: 05/Jan/16 11:37
• Resolved: 02/Apr/15 08:17

Description

This definitely worked before 2.3.20, but unfortunately I haven’t been able to track down the actual source of the bug introduced for 2.3.20. My best guess is that it was introduced when the code was refactored to support Collections.

Basically I have an Action, with a setter and getter for state that uses a custom type convertor like so:

    /** @return the state. */
    @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
    public RegionI getState() {
        return state;
    }

When I submit the action, this type convertor is correctly used to turn the “state” post parameter into a RegionI object which is injected into the Action. So far so good.

However, the result looks like:

      <result name="selfSignupFlow" type="redirectAction">
         <param name="actionName">confirmAccount</param>
         <param name="streetAddress">${streetAddress}</param>
         <param name="city">${city}</param>
         <param name="state">${state}</param>
         <param name="postalCode">${postalCode}</param>
	    ...
      </result>

And in the latest release, when it evaluates ${state} it uses the default type convertor (in this case for an enum because the concrete class is a USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor specified on both the getter and setter for state in the action.

Issue Links

• is broken by: WW-4224 Collection Parameters for RedirectResults