Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4435

CXF broken with upgrade of ASM 5 since Struts 2.3.20

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.20
    • Fix Version/s: 2.3.24
    • Component/s: Integration
    • Labels:
    • Flags:
      Patch, Important

      Description

      Hi,

      Since upgrade of Struts in 2.3.20, the version of ASM has been upgraded to 5.0.2.

      Actually, I use CXF with Struts 2.

      The problem is CXF uses ASM 3.x and it's not compatible with the new API of ASM 5.0.2. All interfaces *Visitor.java have been replaced with abstract classes and the class "WrapperClassGenerator" in CXF is broken because it uses the interfaces "AnnotationVisitor", "FieldVisitor" and "MethodVisitor".

      Why do you upgrade ASM 3.3 to ASM 5.0.2 (four years between the two versions!) with this patch of Struts 2 (2.3.20)?

      Is there a workaround?

      Thank you in advance.

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 73644d2ccf147cc131fc5a65ab6bce6255fdc67c in struts's branch refs/heads/develop from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=73644d2 ]

          Merge branch 'develop' into WW-4435

          Show
          jira-bot ASF subversion and git services added a comment - Commit 73644d2ccf147cc131fc5a65ab6bce6255fdc67c in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=73644d2 ] Merge branch 'develop' into WW-4435
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3bf67283e78002344b5c46f96d7582f0d257c683 in struts's branch refs/heads/develop from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3bf6728 ]

          WW-4435 Allows use different versions of ASM

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3bf67283e78002344b5c46f96d7582f0d257c683 in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3bf6728 ] WW-4435 Allows use different versions of ASM
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          New plugin defined - Struts 2 Java 8 plugin
          https://github.com/apache/struts/tree/develop/plugins/java8-support

          Show
          lukaszlenart Lukasz Lenart added a comment - New plugin defined - Struts 2 Java 8 plugin https://github.com/apache/struts/tree/develop/plugins/java8-support
          Hide
          sepe81 Sebastian Peters added a comment -

          Lukasz Lenart This issue has been resolved over a month ago and the version summary for 2.3.21 in JIRA tells me Due:31/Dec/14. Could you please tell me, when it will be released and ready for download under http://struts.apache.org/download.cgi?

          I guess there is more than one project depending on Struts2 and CXF in combination. In this scenario version 2.3.20 isn't a stable version in my opinion.

          According to the issue list there are no open issues for 2.3.21. Is any more feedback needed for the final release?

          Thanks for your support
          Sebastian

          Show
          sepe81 Sebastian Peters added a comment - Lukasz Lenart This issue has been resolved over a month ago and the version summary for 2.3.21 in JIRA tells me Due:31/Dec/14. Could you please tell me, when it will be released and ready for download under http://struts.apache.org/download.cgi? I guess there is more than one project depending on Struts2 and CXF in combination. In this scenario version 2.3.20 isn't a stable version in my opinion. According to the issue list there are no open issues for 2.3.21. Is any more feedback needed for the final release? Thanks for your support Sebastian
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          2.3.21 didn't pass the Vote - http://markmail.org/message/tlevd2vbnqo7lujo - you can use the staging repo or dev download as mentioned in the thread. 2.3.22 is in pipeline now so it will contain fixes from 2.3.21

          Show
          lukaszlenart Lukasz Lenart added a comment - 2.3.21 didn't pass the Vote - http://markmail.org/message/tlevd2vbnqo7lujo - you can use the staging repo or dev download as mentioned in the thread. 2.3.22 is in pipeline now so it will contain fixes from 2.3.21
          Hide
          philvarner Phil Varner added a comment -

          I had the same issue and was able to run CXF compiled for ASM 3 with ASM 5 and my own application's use of ASM with ASM 5 (which uses ASM 5 indirectly through cglib 3.1. cglib 3.1 is compiled against ASM 4, but will run with ASM 5).

          Written up here: http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/

          Show
          philvarner Phil Varner added a comment - I had the same issue and was able to run CXF compiled for ASM 3 with ASM 5 and my own application's use of ASM with ASM 5 (which uses ASM 5 indirectly through cglib 3.1. cglib 3.1 is compiled against ASM 4, but will run with ASM 5). Written up here: http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/
          Hide
          sepe81 Sebastian Peters added a comment -

          I can confirm that the fix is working with the just released version 2.3.24. Thanks a lot!

          Show
          sepe81 Sebastian Peters added a comment - I can confirm that the fix is working with the just released version 2.3.24. Thanks a lot!

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              Canni Fabrice Cannizzaro
            • Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development