Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4433

ConventionUnknownHandler change breaks exception handling in interceptors.

    Details

      Description

      Struts 2.3.20 appears to have caused a regression that prevents exceptions thrown from convention-plugin actions from reaching ExceptionMappingInterceptor. This breaks exception handling when using the convention-plugin.

      To Reproduce:

      • Generate a project struts2-archetype-convention archetype using 2.3.20
      • Throw exception in the action. With 2.3.20, a blank page is shown.
      • Change to 2.3.16.3 and you will get the standard struts2 error page.

      The breaking change appears to have been made in WW-4331. This causes error interceptor code to break (showing a blank page when exceptions are thrown) as DefaultActionInvocation does not catch an exception from the default UnknownHandler implementation execution, which would previously re-throw the original exception back up for the interceptors to catch.

      Workaround:

      We've created our own UnknownHandler implementation that just throws a new NoSuchMethodException, allowing DefaultActionInvocation to re-throw the original exception so that our error interceptor can again catch it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lukaszlenart Lukasz Lenart
                Reporter:
                jwolschon Joseph Wolschon
              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: