Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4427

Converters no longer applied to values coming from the context

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.16.1
    • Fix Version/s: 2.3.24
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context.

      1. struts_patch.diff
        1 kB
        Przemek Bruski

        Activity

        Hide
        pbruski_ Przemek Bruski added a comment -

        BTW, if this is a proper fix, I am happy to write UTs for it.

        Show
        pbruski_ Przemek Bruski added a comment - BTW, if this is a proper fix, I am happy to write UTs for it.
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Feel free! You can also use GitHub's Pull Requests -> https://github.com/apache/struts/pulls

        Show
        lukaszlenart Lukasz Lenart added a comment - Feel free! You can also use GitHub's Pull Requests -> https://github.com/apache/struts/pulls
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user pbruski opened a pull request:

        https://github.com/apache/struts/pull/32

        WW-4427 - Converters are no longer applied to values coming from the context

        fix and UT

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/pbruski/struts develop

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/32.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #32


        commit 6834b78fe9ec33e90530686e9c5101358750a854
        Author: Przemek Bruski <pbruski@atlassian.com>
        Date: 2014-12-09T16:17:15Z

        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user pbruski opened a pull request: https://github.com/apache/struts/pull/32 WW-4427 - Converters are no longer applied to values coming from the context fix and UT You can merge this pull request into a Git repository by running: $ git pull https://github.com/pbruski/struts develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 6834b78fe9ec33e90530686e9c5101358750a854 Author: Przemek Bruski <pbruski@atlassian.com> Date: 2014-12-09T16:17:15Z WW-4427 - Converters are no longer applied to values coming from the context - fix and UT
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Struts-JDK7-pull-request #14 (See https://builds.apache.org/job/Struts-JDK7-pull-request/14/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-pull-request #14 (See https://builds.apache.org/job/Struts-JDK7-pull-request/14/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on a diff in the pull request:

        https://github.com/apache/struts/pull/32#discussion_r21548312

        — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java —
        @@ -351,6 +351,8 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException {
        value = getValue(expr, asType);
        if (value == null) {
        value = findInContext(expr);
        + final XWorkConverter conv = ((Container)getContext().get(ActionContext.CONTAINER)).getInstance(XWorkConverter.class);
        — End diff –

        Why do you looking for Converter instead of `@Inject` it? You can inject it with
        ```java
        private XWorkConverter conv;

        @Inject
        public void setXWorkConverter(XWorkConverter conv)

        { this.conv = conv; }

        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r21548312 — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java — @@ -351,6 +351,8 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException { value = getValue(expr, asType); if (value == null) { value = findInContext(expr); + final XWorkConverter conv = ((Container)getContext().get(ActionContext.CONTAINER)).getInstance(XWorkConverter.class); — End diff – Why do you looking for Converter instead of `@Inject` it? You can inject it with ```java private XWorkConverter conv; @Inject public void setXWorkConverter(XWorkConverter conv) { this.conv = conv; } ```
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Struts-JDK7-pull-request #15 (See https://builds.apache.org/job/Struts-JDK7-pull-request/15/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-pull-request #15 (See https://builds.apache.org/job/Struts-JDK7-pull-request/15/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Struts-JDK7-pull-request #16 (See https://builds.apache.org/job/Struts-JDK7-pull-request/16/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d)
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-pull-request #16 (See https://builds.apache.org/job/Struts-JDK7-pull-request/16/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on a diff in the pull request:

        https://github.com/apache/struts/pull/32#discussion_r22206741

        — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java —
        @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException {
        value = getValue(expr, asType);
        if (value == null) {
        value = findInContext(expr);
        + return converter.convertValue(getContext(), value, asType);
        — End diff –

        What will happen when value from context is null? Should it be converted? Can you add additional test case?

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r22206741 — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java — @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException { value = getValue(expr, asType); if (value == null) { value = findInContext(expr); + return converter.convertValue(getContext(), value, asType); — End diff – What will happen when value from context is null? Should it be converted? Can you add additional test case?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user lukaszlenart commented on a diff in the pull request:

        https://github.com/apache/struts/pull/32#discussion_r22218137

        — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java —
        @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException {
        value = getValue(expr, asType);
        if (value == null) {
        value = findInContext(expr);
        + return converter.convertValue(getContext(), value, asType);
        — End diff –

        I've added it, time to merge

        Show
        githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r22218137 — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java — @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException { value = getValue(expr, asType); if (value == null) { value = findInContext(expr); + return converter.convertValue(getContext(), value, asType); — End diff – I've added it, time to merge
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6834b78fe9ec33e90530686e9c5101358750a854 in struts's branch refs/heads/develop from Przemek Bruski
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6834b78 ]

        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6834b78fe9ec33e90530686e9c5101358750a854 in struts's branch refs/heads/develop from Przemek Bruski [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6834b78 ] WW-4427 - Converters are no longer applied to values coming from the context - fix and UT
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6a58778399dcdacbe061c55b37a581646871d4ce in struts's branch refs/heads/develop from Przemek Bruski
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6a58778 ]

        WW-4427 - inject the converter instead of getting it directly

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6a58778399dcdacbe061c55b37a581646871d4ce in struts's branch refs/heads/develop from Przemek Bruski [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6a58778 ] WW-4427 - inject the converter instead of getting it directly
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit debaaa2443b854ee0c0cd34ea61ccdc88810e13d in struts's branch refs/heads/develop from Przemek Bruski
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=debaaa2 ]

        WW-4427 - cleaned up UT

        Show
        jira-bot ASF subversion and git services added a comment - Commit debaaa2443b854ee0c0cd34ea61ccdc88810e13d in struts's branch refs/heads/develop from Przemek Bruski [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=debaaa2 ] WW-4427 - cleaned up UT
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 60db1aadb087a71f89aa49d2b5062b02a2c2ae3f in struts's branch refs/heads/develop from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=60db1aa ]

        WW-4427 Converts value retrieved from context

        Show
        jira-bot ASF subversion and git services added a comment - Commit 60db1aadb087a71f89aa49d2b5062b02a2c2ae3f in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=60db1aa ] WW-4427 Converts value retrieved from context
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/struts/pull/32

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/32
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        PR merged, thanks!

        Show
        lukaszlenart Lukasz Lenart added a comment - PR merged, thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK6-develop #114 (See https://builds.apache.org/job/Struts-JDK6-develop/114/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d)
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK6-develop #114 (See https://builds.apache.org/job/Struts-JDK6-develop/114/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user pbruski commented on a diff in the pull request:

        https://github.com/apache/struts/pull/32#discussion_r22236102

        — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java —
        @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException {
        value = getValue(expr, asType);
        if (value == null) {
        value = findInContext(expr);
        + return converter.convertValue(getContext(), value, asType);
        — End diff –

        thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user pbruski commented on a diff in the pull request: https://github.com/apache/struts/pull/32#discussion_r22236102 — Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java — @@ -351,6 +352,7 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException { value = getValue(expr, asType); if (value == null) { value = findInContext(expr); + return converter.convertValue(getContext(), value, asType); — End diff – thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-pull-request #21 (See https://builds.apache.org/job/Struts-JDK7-pull-request/21/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d)
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-pull-request #21 (See https://builds.apache.org/job/Struts-JDK7-pull-request/21/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Struts-JDK6-master #901 (See https://builds.apache.org/job/Struts-JDK6-master/901/)
        WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d)
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Struts-JDK6-master #901 (See https://builds.apache.org/job/Struts-JDK6-master/901/ ) WW-4427 - Converters are no longer applied to values coming from the context - fix and UT (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user pbruski opened a pull request:

        https://github.com/apache/struts/pull/36

        WW-4427 - Converters are no longer applied to values coming from the context on error path

        The previous fix was incomplete.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/pbruski/struts develop

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/36.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #36


        commit e0d72397c24542a8b83a371a36590570ccd8fd74
        Author: Przemek Bruski <pbruski@atlassian.com>
        Date: 2015-02-15T09:40:13Z

        WW-4427 - Converters are no longer applied to values coming from the context on error path


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user pbruski opened a pull request: https://github.com/apache/struts/pull/36 WW-4427 - Converters are no longer applied to values coming from the context on error path The previous fix was incomplete. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pbruski/struts develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit e0d72397c24542a8b83a371a36590570ccd8fd74 Author: Przemek Bruski <pbruski@atlassian.com> Date: 2015-02-15T09:40:13Z WW-4427 - Converters are no longer applied to values coming from the context on error path
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-pull-request #25 (See https://builds.apache.org/job/Struts-JDK7-pull-request/25/)
        WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-pull-request #25 (See https://builds.apache.org/job/Struts-JDK7-pull-request/25/ ) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e0d72397c24542a8b83a371a36590570ccd8fd74 in struts's branch refs/heads/develop from Przemek Bruski
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e0d7239 ]

        WW-4427 - Converters are no longer applied to values coming from the context on error path

        Show
        jira-bot ASF subversion and git services added a comment - Commit e0d72397c24542a8b83a371a36590570ccd8fd74 in struts's branch refs/heads/develop from Przemek Bruski [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e0d7239 ] WW-4427 - Converters are no longer applied to values coming from the context on error path
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 66248a80e3b238092bf547cc196ad2f7b0225b76 in struts's branch refs/heads/develop from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=66248a8 ]

        WW-4427 adds complete fix

        Show
        jira-bot ASF subversion and git services added a comment - Commit 66248a80e3b238092bf547cc196ad2f7b0225b76 in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=66248a8 ] WW-4427 adds complete fix
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/struts/pull/36

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/36
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        PR merged, thanks!

        Show
        lukaszlenart Lukasz Lenart added a comment - PR merged, thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK6-develop #132 (See https://builds.apache.org/job/Struts-JDK6-develop/132/)
        WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74)

        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK6-develop #132 (See https://builds.apache.org/job/Struts-JDK6-develop/132/ ) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK6-master #904 (See https://builds.apache.org/job/Struts-JDK6-master/904/)
        WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74)

        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK6-master #904 (See https://builds.apache.org/job/Struts-JDK6-master/904/ ) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/)
        WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854)

        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
          WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d)
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
          WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74)
        • xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
        • xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/ ) WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev 6834b78fe9ec33e90530686e9c5101358750a854) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - inject the converter instead of getting it directly (pbruski: rev 6a58778399dcdacbe061c55b37a581646871d4ce) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java WW-4427 - cleaned up UT (pbruski: rev debaaa2443b854ee0c0cd34ea61ccdc88810e13d) xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java WW-4427 - Converters are no longer applied to values coming from the (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            pbruski_ Przemek Bruski
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development