Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4391

FreemarkerResult should respect response.getCharacterEncoding()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.5.8
    • Component/s: Core Actions
    • Labels:
      None
    • Flags:
      Patch

      Description

      response.getCharacterEncoding() should override template.getEncoding() if exists.

      1. WW-4391.patch
        0.7 kB
        zhouyanming

        Issue Links

          Activity

          Hide
          quaff zhouyanming added a comment -

          here is patch

          Show
          quaff zhouyanming added a comment - here is patch
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1a034053bcf82ce05fe21680ca658ddae03bb159 in struts's branch refs/heads/develop from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=1a03405 ]

          WW-4391 FreemarkerResult uses response content encoding in first place

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1a034053bcf82ce05fe21680ca658ddae03bb159 in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=1a03405 ] WW-4391 FreemarkerResult uses response content encoding in first place
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          Slightly modified patch applied, thanks!

          Show
          lukaszlenart Lukasz Lenart added a comment - Slightly modified patch applied, thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Struts-JDK6-develop #76 (See https://builds.apache.org/job/Struts-JDK6-develop/76/)
          WW-4391 FreemarkerResult uses response content encoding in first place (lukaszlenart: rev 1a034053bcf82ce05fe21680ca658ddae03bb159)

          • core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Struts-JDK6-develop #76 (See https://builds.apache.org/job/Struts-JDK6-develop/76/ ) WW-4391 FreemarkerResult uses response content encoding in first place (lukaszlenart: rev 1a034053bcf82ce05fe21680ca658ddae03bb159) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          This breaks WW-4420 as I have no solution how to get it working as previously, I will revert the changes introduced by the patch.

          Show
          lukaszlenart Lukasz Lenart added a comment - This breaks WW-4420 as I have no solution how to get it working as previously, I will revert the changes introduced by the patch.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e1025a207ddfa1b8971ec6261ea2c09da2af157f in struts's branch refs/heads/develop from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e1025a2 ]

          WW-4391 reverts changes as this breaks WW-4420

          Show
          jira-bot ASF subversion and git services added a comment - Commit e1025a207ddfa1b8971ec6261ea2c09da2af157f in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e1025a2 ] WW-4391 reverts changes as this breaks WW-4420
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Struts-JDK6-develop #101 (See https://builds.apache.org/job/Struts-JDK6-develop/101/)
          WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f)

          • core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK6-develop #101 (See https://builds.apache.org/job/Struts-JDK6-develop/101/ ) WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e1025a207ddfa1b8971ec6261ea2c09da2af157f in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e1025a2 ]

          WW-4391 reverts changes as this breaks WW-4420

          Show
          jira-bot ASF subversion and git services added a comment - Commit e1025a207ddfa1b8971ec6261ea2c09da2af157f in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e1025a2 ] WW-4391 reverts changes as this breaks WW-4420
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Struts-JDK6-master #899 (See https://builds.apache.org/job/Struts-JDK6-master/899/)
          WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f)

          • core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK6-master #899 (See https://builds.apache.org/job/Struts-JDK6-master/899/ ) WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in Struts-JDK7-pull-request #17 (See https://builds.apache.org/job/Struts-JDK7-pull-request/17/)
          WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f)

          • core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-pull-request #17 (See https://builds.apache.org/job/Struts-JDK7-pull-request/17/ ) WW-4391 reverts changes as this breaks WW-4420 (lukaszlenart: rev e1025a207ddfa1b8971ec6261ea2c09da2af157f) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerResult.java
          Hide
          victorsosa victorsosa added a comment -

          We still want to do this?? it seems like this is a WON'T FIX

          Show
          victorsosa victorsosa added a comment - We still want to do this?? it seems like this is a WON'T FIX
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          Rather there is no good idea how to implement this without breaking other things.

          Show
          lukaszlenart Lukasz Lenart added a comment - Rather there is no good idea how to implement this without breaking other things.
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          This can be implemented as response.getCharacterEncoding() always returns ISO-8859-1 if not character has been specifying.

          Show
          lukaszlenart Lukasz Lenart added a comment - This can be implemented as response.getCharacterEncoding() always returns ISO-8859-1 if not character has been specifying.

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              quaff zhouyanming
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development