Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.16.3
    • Fix Version/s: 2.3.20
    • Component/s: None
    • Environment:

      JBoss AS 7.x and JBoss EAP 6.x, JVM 1.7

      Description

      This improvement enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module.

      Issue:
      having two or more applications using the same "struts-module" (meant as JBoss AS 7 module),
      each application with its own resource bundle, the first one which initialized the LocalizedTextUtil "wins" over the second and next application's resource bundles. Furthermore, to avoid overwriting bundles, now each bundle is indexed into the bundlesMap by its key (resourceBundleName) and prefixed by ClassLoader hash code.

        Activity

        Hide
        lukaszlenart Lukasz Lenart added a comment -

        PR applied, thanks!

        Show
        lukaszlenart Lukasz Lenart added a comment - PR applied, thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user foogaro opened a pull request:

        https://github.com/apache/struts/pull/20

        Localized by classloader

        *This improvement enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module.*

        *Issue:*
        having two or more applications using the same "struts-module" (meant as JBoss AS 7 module),
        each application with its own resource bundle, the first one which initialized the LocalizedTextUtil "wins" over the second and next application's resource bundles. Furthermore, to avoid overwriting bundles, now each bundle is indexed into the bundlesMap by its key (resourceBundleName) and prefixed by ClassLoader hash code.

        https://issues.apache.org/jira/browse/WW-4379

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/redhat-italy/struts localized-by-classloader

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/struts/pull/20.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #20


        commit 2de0f4b5b10627c53f85a895d310fdaa53c0d2b0
        Author: Luigi Fugaro <l.fugaro@gmail.com>
        Date: 2014-07-29T15:44:28Z

        This update enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module.

        commit 4586d1f148ef43c7582038306a626144c75d0e49
        Author: Luigi Fugaro <l.fugaro@gmail.com>
        Date: 2014-07-29T15:46:04Z

        Added pom's version as 2.3.16.4-SNAPSHOT

        commit c826d97cafafc9ce54e15745b23cd211e233c2fa
        Author: Luigi Fugaro <l.fugaro@gmail.com>
        Date: 2014-07-29T16:44:50Z

        Removed unused code, comments and variables. Also, added delegatedClassLoaderMap to handle delegatedClassLoader as per Tomcat.

        commit d65270b9bb061bf16072e706f53060d3d9ab78ca
        Author: Luigi Fugaro <l.fugaro@gmail.com>
        Date: 2014-07-30T09:42:46Z

        Deleted internal versioning.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user foogaro opened a pull request: https://github.com/apache/struts/pull/20 Localized by classloader * This improvement enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module. * * Issue: * having two or more applications using the same "struts-module" (meant as JBoss AS 7 module), each application with its own resource bundle, the first one which initialized the LocalizedTextUtil "wins" over the second and next application's resource bundles. Furthermore, to avoid overwriting bundles, now each bundle is indexed into the bundlesMap by its key (resourceBundleName) and prefixed by ClassLoader hash code. https://issues.apache.org/jira/browse/WW-4379 You can merge this pull request into a Git repository by running: $ git pull https://github.com/redhat-italy/struts localized-by-classloader Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 2de0f4b5b10627c53f85a895d310fdaa53c0d2b0 Author: Luigi Fugaro <l.fugaro@gmail.com> Date: 2014-07-29T15:44:28Z This update enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module. commit 4586d1f148ef43c7582038306a626144c75d0e49 Author: Luigi Fugaro <l.fugaro@gmail.com> Date: 2014-07-29T15:46:04Z Added pom's version as 2.3.16.4-SNAPSHOT commit c826d97cafafc9ce54e15745b23cd211e233c2fa Author: Luigi Fugaro <l.fugaro@gmail.com> Date: 2014-07-29T16:44:50Z Removed unused code, comments and variables. Also, added delegatedClassLoaderMap to handle delegatedClassLoader as per Tomcat. commit d65270b9bb061bf16072e706f53060d3d9ab78ca Author: Luigi Fugaro <l.fugaro@gmail.com> Date: 2014-07-30T09:42:46Z Deleted internal versioning.

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            foogaro Luigi Fugaro
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development