[WW-4354] ParametersInterceptor's isWithinLengthLimit() method ignores devMode

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.3.16.3
• Fix Version/s: 2.3.20
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: Andreas Wolf
• Created: 28/May/14 11:52
• Updated: 28/May/14 12:14
• Resolved: 28/May/14 12:14

Description

In the Class com.opensymphony.xwork2.interceptor.ParametersInterceptor
the method isWithinLengthLimit( String name ) does not consider the devMode flag.

protected boolean isWithinLengthLimit( String name ) {
        boolean matchLength = name.length() <= paramNameMaxLength;
        if (!matchLength) {
            notifyDeveloper("Parameter [#0] is too long, allowed length is [#1]", name, String.valueOf(paramNameMaxLength));
        }
        return matchLength;
}

As a result, an ERROR is logged when a Paramter is too long.
E.g.
[com.opensymphony.xwork2.interceptor.ParametersInterceptor] [Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting '****' on 'class java.lang.String: 100]

Issue Links

• duplicates: WW-4264 notifyDeveloper method logs error even when devMode is set false