[WW-4350] OgnlValueStack causes race condition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.16.1
• Fix Version/s: 2.3.20
• Component/s: Core Actions, Value Stack
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Sergey Gromov
• Created: 21/May/14 12:11
• Updated: 13/Jan/15 11:58
• Resolved: 11/Jul/14 06:58

Description

com.opensymphony.xwork2.ognl.accessor.CompoundRootAccessor.callMethod is not thread safe because of unsynchronized reads and writes to HashMap:

private static Map invalidMethods = new HashMap();
...
public Object callMethod(Map context, Object target, String name, Object[] objects) throws MethodFailedException {
    ...
    if ((argTypes == null) || !invalidMethods.containsKey(mc)) {
        ...
        invalidMethods.put(mc, Boolean.TRUE);
        ...
    }
    ...
}

Propose to use ConcurrentHashMap