Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4340

Grouping same type validators

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.5.x
    • Component/s: XML Validators
    • Labels:

      Description

      In a middle sized application there may be hundreds of required fields, and maybe dozens of some other validator type, which are all very verbose to define.

      For instance: guess a big form with many required fields:

          <validator type="requiredstring">
              <param name="fieldname">person.firstName</param>
              <message>First name is required.</message>
          </validator>
          <validator type="requiredstring">
              <param name="fieldname">person.lastName</param>
              <message>Last name is required.</message>
          </validator>
          ... same for age...
          ... same for manymore...
      

      This is repeating the same pattern for both defining the validator and the corresponding message.

      It would be great to have an abbreviated syntax, for instance (pseudo-language):

          <validator type="requiredstring">
              <param name="fieldname">person.lastName, person.lastName, person.age, person.manymore</param>
              <message>[MATCHED_FIELDNAME] is required.</message>
          </validator>
      

      or

          <validator type="requiredstring">
              <param name="fieldname">person.lastName, person.lastName, person.age, person.manymore</param>
              <message key="requiredField" />
          </validator>
      

      and 'global_validation_messages.properties' having

          requiredField = [MATCHED_FIELDNAME] is required. 
      

      Not only "required" validator, but any other one.

      Advantages:

      1. Message is defined once. It is easy to uniformly change 'Field is required' to 'Please, fill this field".

      2. Define affected fields all in a row. If my form has 10 required field, then 10 validation definitions are currently needed. With this improvement, only 1 definition is needed.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              antonioares Antonio Sánchez
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: