[WW-4275] Cast exception on Supressing empty parameters on <s:a> tag

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.16
• Fix Version/s: 2.3.20
• Component/s: Plugin - Java Templates

Environment

Tomcat/Centos

• Assignee: Greg Huber
• Reporter: Greg Huber
• Created: 10/Jan/14 10:52
• Updated: 22/Apr/14 09:14
• Resolved: 10/Jan/14 15:08

Description

I have noticed that my patch does not handle integers correctly, alas, we need to do another change

It does kind of the same check, but this works with integers/doubles.

Object value = findValue(this.value);
if (suppressEmptyParameters) {
if (value != null && !value.toString().isEmpty()){ 
  component.addParameter(name, value); }
} else{
  component.addParameter(name, value); 
}

existing code:

if (suppressEmptyParameters) {
String potentialValue = (String) value;
if (potentialValue != null && potentialValue.length() > 0) { component.addParameter(name, value); }
} else { component.addParameter(name, value); }

Issue Links

• is broken by: WW-4088 Supressing empty parameters on <s:a> tag