Struts 2
  1. Struts 2
  2. WW-4267

When devMode is enabled via CustomConfigProvider it is not possible to enable reloading automatically

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3.16
    • Fix Version/s: 2.3.20
    • Component/s: XML Configuration
    • Labels:
      None

      Description

      When devMode is enbaled the framework used to enable some other debug options per default, like reloading of config and resources. In 2.3.16 that was changed to be able to have devMode without all of those other options. The reason for that are performance issues with freemarker debug options.

      A side effect of that is that automatic enablement of reloading does not work anymore when devMode is enabled via a CustomConfigProvider.

      To fix that default settings in default.properties can be outcommented. That way it does not take effect at runtime but is still present for developers to read the file.

      These properties are affected:

      • struts.i18n.reload
      • struts.configuration.xml.reload
      • struts.freemarker.templatesCache
      • struts.freemarker.templatesCache.updateDelay

        Activity

        Christoph Nenning created issue -
        Lukasz Lenart made changes -
        Field Original Value New Value
        Fix Version/s 2.3.17 [ 12324780 ]
        Lukasz Lenart made changes -
        Assignee Lukasz Lenart [ lukaszlenart ]
        Show
        Lukasz Lenart added a comment - Changes are here https://git-wip-us.apache.org/repos/asf?p=struts.git;a=shortlog;h=refs/heads/feature/WW-4267-removes-defaults
        Hide
        ASF subversion and git services added a comment -

        Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/develop from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ]

        Merge branch 'develop' into feature/WW-4267-removes-defaults

        Show
        ASF subversion and git services added a comment - Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ] Merge branch 'develop' into feature/ WW-4267 -removes-defaults
        Hide
        ASF subversion and git services added a comment -

        Commit 4fbfa3b8b2a71a36a55fec0a25dbc00939e3fdf9 in struts's branch refs/heads/develop from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4fbfa3b ]

        WW-4267 finishes merging changes to develop

        Show
        ASF subversion and git services added a comment - Commit 4fbfa3b8b2a71a36a55fec0a25dbc00939e3fdf9 in struts's branch refs/heads/develop from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4fbfa3b ] WW-4267 finishes merging changes to develop
        Hide
        ASF subversion and git services added a comment -

        Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/feature/WW-4267-removes-defaults from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ]

        Merge branch 'develop' into feature/WW-4267-removes-defaults

        Show
        ASF subversion and git services added a comment - Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/feature/ WW-4267 -removes-defaults from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ] Merge branch 'develop' into feature/ WW-4267 -removes-defaults
        Hide
        Lukasz Lenart added a comment -

        Done!

        Show
        Lukasz Lenart added a comment - Done!
        Lukasz Lenart made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        ASF subversion and git services added a comment -

        Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/feature/use-js-to-support-multiple-buttons from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ]

        Merge branch 'develop' into feature/WW-4267-removes-defaults

        Show
        ASF subversion and git services added a comment - Commit bd2a5ea8d5f5dc6468f4883c0768066f4e721fe1 in struts's branch refs/heads/feature/use-js-to-support-multiple-buttons from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bd2a5ea ] Merge branch 'develop' into feature/ WW-4267 -removes-defaults
        Hide
        ASF subversion and git services added a comment -

        Commit 4fbfa3b8b2a71a36a55fec0a25dbc00939e3fdf9 in struts's branch refs/heads/feature/use-js-to-support-multiple-buttons from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4fbfa3b ]

        WW-4267 finishes merging changes to develop

        Show
        ASF subversion and git services added a comment - Commit 4fbfa3b8b2a71a36a55fec0a25dbc00939e3fdf9 in struts's branch refs/heads/feature/use-js-to-support-multiple-buttons from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4fbfa3b ] WW-4267 finishes merging changes to develop
        Lukasz Lenart made changes -
        Fix Version/s 2.3.18 [ 12319176 ]
        Fix Version/s 2.3.17 [ 12324780 ]
        Lukasz Lenart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Lukasz Lenart
            Reporter:
            Christoph Nenning
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development