Struts 2
  1. Struts 2
  2. WW-4260

themes.properties cannot be loaded using ServletContext

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.16
    • Fix Version/s: 2.3.20
    • Component/s: Integration
    • Labels:
      None

      Description

      Right now when defining a new theme and overriding just separated files, all the files and themes.properties must lay under classpath (e.g. in src/main/resources when using Maven).

      This all is because TemplateEngine doesn't use ServletContext to resolve path to themes.properties.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1551478 from Lukasz Lenart in branch 'struts2/trunk'
          [ https://svn.apache.org/r1551478 ]

          WW-4260 Uses ServletContext to load themes.properties from

          Show
          ASF subversion and git services added a comment - Commit 1551478 from Lukasz Lenart in branch 'struts2/trunk' [ https://svn.apache.org/r1551478 ] WW-4260 Uses ServletContext to load themes.properties from
          Hide
          Lukasz Lenart added a comment -

          Extended BaseTemplateEngine to use also ServletContext to load themes.properties - right now template folder can be placed under webapp folder as well!

          Show
          Lukasz Lenart added a comment - Extended BaseTemplateEngine to use also ServletContext to load themes.properties - right now template folder can be placed under webapp folder as well!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Struts2-JDK6 #856 (See https://builds.apache.org/job/Struts2-JDK6/856/)
          WW-4260 Uses ServletContext to load themes.properties from (lukaszlenart: rev 1551478)

          • /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/BaseTemplateEngine.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Struts2-JDK6 #856 (See https://builds.apache.org/job/Struts2-JDK6/856/ ) WW-4260 Uses ServletContext to load themes.properties from (lukaszlenart: rev 1551478) /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/BaseTemplateEngine.java

            People

            • Assignee:
              Lukasz Lenart
              Reporter:
              Lukasz Lenart
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development