Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.15
    • Fix Version/s: 2.5
    • Component/s: Value Stack
    • Labels:
      None

      Issue Links

        Activity

        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Version notes for OGNL are here: https://github.com/jkuhnert/ognl

        Show
        lukaszlenart Lukasz Lenart added a comment - Version notes for OGNL are here: https://github.com/jkuhnert/ognl
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Postponed as this breaks too many things.

        Show
        lukaszlenart Lukasz Lenart added a comment - Postponed as this breaks too many things.
        Hide
        mlw5415 lwen.ma added a comment -

        @Lukasz Lenart We have upgrade to ognl 3.0.8 to product env about two weeks ago, and it work well till now.

        Show
        mlw5415 lwen.ma added a comment - @Lukasz Lenart We have upgrade to ognl 3.0.8 to product env about two weeks ago, and it work well till now.
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        But it fails when I want to build S2 - there is a bug in uppercasing property names and something is wrong when expression affects public static classes.

        Show
        lukaszlenart Lukasz Lenart added a comment - But it fails when I want to build S2 - there is a bug in uppercasing property names and something is wrong when expression affects public static classes.
        Show
        lukaszlenart Lukasz Lenart added a comment - It's already solved https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
        Hide
        rgielen Rene Gielen added a comment - - edited

        I make a case for upgrading to OGNL 3.0.9, for which I hope the following change will be applied

        • Upgrade javassist dependency to 3.1.18

        The reason is that current version is not only incompatible with Hibernate 4, but also with JDK8. Incompatibility with Hibernate 4 is due to the fact that javassisst groupId unfortunately changed from javassist to org.javassist. Thus you get two javassist jar in your built artifact. Currently, to incorporate Hibernate and other libraries introducing transitive dependencies to newer javassist coordinates and versions, one has to exclude "old" dependency from struts-core:

        <dependency>
            <groupId>org.apache.struts</groupId>
            <artifactId>struts2-core</artifactId>
            <version>${struts2.version}</version>
            <exclusions>
                <exclusion>
                    <groupId>javassist</groupId>
                    <artifactId>javassist</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        

        Should I raise an issue for OGNL, and if yes, where?

        Show
        rgielen Rene Gielen added a comment - - edited I make a case for upgrading to OGNL 3.0.9, for which I hope the following change will be applied Upgrade javassist dependency to 3.1.18 The reason is that current version is not only incompatible with Hibernate 4, but also with JDK8. Incompatibility with Hibernate 4 is due to the fact that javassisst groupId unfortunately changed from javassist to org.javassist. Thus you get two javassist jar in your built artifact. Currently, to incorporate Hibernate and other libraries introducing transitive dependencies to newer javassist coordinates and versions, one has to exclude "old" dependency from struts-core: <dependency> <groupId> org.apache.struts </groupId> <artifactId> struts2-core </artifactId> <version> ${struts2.version} </version> <exclusions> <exclusion> <groupId> javassist </groupId> <artifactId> javassist </artifactId> </exclusion> </exclusions> </dependency> Should I raise an issue for OGNL, and if yes, where?
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        No that's ok

        Show
        lukaszlenart Lukasz Lenart added a comment - No that's ok
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3bbe681346339a671b7e3c986f041ce415848dff in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3bbe681 ]

        WW-4207 Upgrades OGNL to latest available version

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3bbe681346339a671b7e3c986f041ce415848dff in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3bbe681 ] WW-4207 Upgrades OGNL to latest available version
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Used the latest available version - 3.0.11 - and this version breaks access to properties as it follows Java Bean Specification and now if property is named as aLong access to it via expression will be "%ALong"

        Show
        lukaszlenart Lukasz Lenart added a comment - Used the latest available version - 3.0.11 - and this version breaks access to properties as it follows Java Bean Specification and now if property is named as aLong access to it via expression will be "%ALong"
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-master #323 (See https://builds.apache.org/job/Struts-JDK7-master/323/)
        WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff)

        • core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
        • pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-master #323 (See https://builds.apache.org/job/Struts-JDK7-master/323/ ) WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java pom.xml
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Struts-JDK7-pull-request #41 (See https://builds.apache.org/job/Struts-JDK7-pull-request/41/)
        WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff)

        • pom.xml
        • core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Struts-JDK7-pull-request #41 (See https://builds.apache.org/job/Struts-JDK7-pull-request/41/ ) WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff) pom.xml core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/)
        WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff)

        • pom.xml
        • core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Struts-JDK7-master #371 (See https://builds.apache.org/job/Struts-JDK7-master/371/ ) WW-4207 Upgrades OGNL to latest available version (lukaszlenart: rev 3bbe681346339a671b7e3c986f041ce415848dff) pom.xml core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            lukaszlenart Lukasz Lenart
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development