Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4095

cleanupActionName should not compile regex every request

VotersStop watchingWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.3.15
    • Core Actions
    • None
    • Patch, Important

    Description

      Please find attached patch proposal, cuts execution time in half.

      Run time compiled regex: 174ms 100000 rounds
      Run time runtime regex: 258ms 100000 rounds
      Run time compiled regex: 166ms 100000 rounds
      Run time runtime regex: 248ms 100000 rounds

      Attachments

        Issue Links

        is related to

        Bug - A problem which impairs or prevents the functions of the product. WW-4090 Remote code execution via wildcard matching and double evaluation of OGNL expression

        • Blocker - Blocks development and/or testing work, production could not run
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            lukaszlenart Lukasz Lenart
            johno Johno Crawford
            Votes:
            0 Vote for this issue
            Watchers:
            5 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment