Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-3973

WW-3866 overrides ParameterNameAware decision with interceptor settings

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.7
    • Fix Version/s: 2.3.12
    • Component/s: None
    • Labels:
      None

      Description

      The fix for WW-3866 (Revision 1379386) changes the logic for acceptable parameter names from

      com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.
              boolean acceptableName = acceptableName(name)
                       && (parameterNameAware == null || parameterNameAware.acceptableParameterName(name));
      

      to

      com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.
              boolean acceptableName = acceptableName(name)
                       || (parameterNameAware != null && parameterNameAware.acceptableParameterName(name));
      

      This might impose a security risk if implementations relied on their actions for parameter name validation (e.g. by explicitly whitelisting parameters).

        Attachments

          Activity

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              clenggenhager Christoph Lenggenhager
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: