[WW-3973] WW-3866 overrides ParameterNameAware decision with interceptor settings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.3.7
• Fix Version/s: 2.3.12
• Assignee: Lukasz Lenart
• Reporter: Christoph Lenggenhager
• Created: 22/Jan/13 16:23
• Updated: 17/May/13 15:12
• Resolved: 28/Jan/13 14:17

Description

The fix for WW-3866 (Revision 1379386) changes the logic for acceptable parameter names from

com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.

        boolean acceptableName = acceptableName(name)
                 && (parameterNameAware == null || parameterNameAware.acceptableParameterName(name));

to

com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.

        boolean acceptableName = acceptableName(name)
                 || (parameterNameAware != null && parameterNameAware.acceptableParameterName(name));

This might impose a security risk if implementations relied on their actions for parameter name validation (e.g. by explicitly whitelisting parameters).