Struts 2
  1. Struts 2
  2. WW-3973

WW-3866 overrides ParameterNameAware decision with interceptor settings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.7
    • Fix Version/s: 2.3.12
    • Component/s: None
    • Labels:
      None

      Description

      The fix for WW-3866 (Revision 1379386) changes the logic for acceptable parameter names from

      com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.
              boolean acceptableName = acceptableName(name)
                       && (parameterNameAware == null || parameterNameAware.acceptableParameterName(name));
      

      to

      com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.
              boolean acceptableName = acceptableName(name)
                       || (parameterNameAware != null && parameterNameAware.acceptableParameterName(name));
      

      This might impose a security risk if implementations relied on their actions for parameter name validation (e.g. by explicitly whitelisting parameters).

        Activity

        Lukasz Lenart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Lukasz Lenart made changes -
        Fix Version/s 2.3.12 [ 12324067 ]
        Fix Version/s 2.3.11 [ 12323903 ]
        Lukasz Lenart made changes -
        Fix Version/s 2.3.11 [ 12323903 ]
        Fix Version/s 2.3.10 [ 12323841 ]
        Lukasz Lenart made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Lukasz Lenart [ lukaszlenart ]
        Resolution Won't Fix [ 2 ]
        Lukasz Lenart made changes -
        Field Original Value New Value
        Fix Version/s 2.3.9 [ 12323841 ]
        Christoph Lenggenhager created issue -

          People

          • Assignee:
            Lukasz Lenart
            Reporter:
            Christoph Lenggenhager
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development