[WW-3920] AnchorHandler does not render onclick() correctly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.4.1
• Fix Version/s: 2.3.12
• Component/s: Plugin - Java Templates
• Assignee: Lukasz Lenart
• Reporter: Greg Huber
• Created: 13/Nov/12 11:29
• Updated: 31/May/13 08:23
• Resolved: 21/Jan/13 21:47

Description

The sripting methods are ignored on the <a/> tag.

It never calls the start on ScriptingEventsHandler so does not add the attributes.

Have checked it with image href links, which is what I think was the reason it was done this way.

public class AnchorHandler extends AbstractTagHandler implements TagGenerator {
    public void generate() throws IOException {
        //all rendering must happend at the end of the tag, so we can support nested params

// Added start

    	Map<String, Object> params = context.getParameters();

        Attributes attrs = new Attributes();

        attrs.addIfExists("name", params.get("name"))
                .addIfExists("id", params.get("id"))
                .addIfExists("class", params.get("cssClass"))
                .addIfExists("style", params.get("cssStyle"))
                .addIfExists("href", params.get("href"), false)
                .addIfExists("title", params.get("title"))
                .addIfExists("tabindex", params.get("tabindex"));
        start("a", attrs);

// added end

    }

    public static class CloseHandler extends AbstractTagHandler implements TagGenerator {
        public void generate() throws IOException {
            Map<String, Object> params = context.getParameters();

// Removed
            /*Attributes attrs = new Attributes();

            attrs.addIfExists("name", params.get("name"))
                    .addIfExists("id", params.get("id"))
                    .addIfExists("class", params.get("cssClass"))
                    .addIfExists("style", params.get("cssStyle"))
                    .addIfExists("href", params.get("href"), false)
                    .addIfExists("title", params.get("title"))
                    .addIfExists("tabindex", params.get("tabindex"));
            start("a", attrs);*/
// removed

            String body = (String) params.get("body");
            if (StringUtils.isNotEmpty(body))
                characters(body, false);
            end("a");
        }
    }

Issue Links

• breaks: WW-4084 Query Parameters Not Included