[WW-3743] XWorkMapPropertyAccessor calls getProperty twice if the value is null

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.1.1
• Fix Version/s: 2.3.3
• Component/s: Value Stack
• Labels: patch performance
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Pelladi Gabor
• Created: 13/Jan/12 12:08
• Updated: 14/Apr/12 06:59
• Resolved: 17/Jan/12 18:14

Description

If you evaluate an OGNL expression which has null value, XWorkMapPropertyAccessor does the evaluation twice.
First in line 81: result = super.getProperty(context, target, name);
Second in line 91: return super.getProperty(context, target, name);

Performance can be improved by removing the second evaluation.
Line 91: return null;
This saves an extra evaluation, and at this point we can be sure that the result can only be null.

Patch is attached.
Please review it.