[WW-3730] action tag accepts only String arrays as parameters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
• Fix Version/s: 6.0.0
• Component/s: Plugin - Tags
• Assignee: Lukasz Lenart
• Reporter: Pavel Kazlou
• Created: 26/Dec/11 15:11
• Updated: 14/Jun/22 09:47
• Resolved: 23/Nov/20 16:33

Description

org.apache.struts2.components.Component accepts arbitrary objects as parameters:

    public Map getParameters() {
        return parameters;
    }

    ...

    public void addParameter(String key, Object value) {
        if (key != null) {
            Map params = getParameters();

            if (value == null) {
                params.remove(key);
            } else {
                params.put(key, value);
            }
        }
    }

But org.apache.struts2.components.ActionComponent explicitly casts all his parameters to String[]:

protected Map<String,String[]> createParametersForContext() {
        Map parentParams = null;

        if (!ignoreContextParams) {
            parentParams = new ActionContext(getStack().getContext()).getParameters();
        }

        Map<String,String[]> newParams = (parentParams != null) 
            ? new HashMap<String,String[]>(parentParams) 
            : new HashMap<String,String[]>();

        if (parameters != null) {
            Map<String,String[]> params = new HashMap<String,String[]>();
            for (Iterator i = parameters.entrySet().iterator(); i.hasNext(); ) {
                Map.Entry entry = (Map.Entry) i.next();
                String key = (String) entry.getKey();
                Object val = entry.getValue();
                if (val.getClass().isArray() && String.class == val.getClass().getComponentType()) {
                    params.put(key, (String[])val);
                } else {
                    params.put(key, new String[]{val.toString()});
                }
            }
            newParams.putAll(params);
        }
        return newParams;
    }

So I can't pass arbitrary objects directly to action using syntax:

<s:action name="myAction"><s:param name="customObject" value="customObject"/></s:action>

without conversion customObject->String->customObject.

Issue Links

• links to: GitHub Pull Request #450