[WW-3691] BackgroundProcess should use a java.util.concurrent.Executor alternatively to spawning a new thread

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.3.1
• Fix Version/s: 6.1.1
• Component/s: Core Interceptors
• Assignee: Lukasz Lenart
• Reporter: Falko Modler
• Created: 10/Oct/11 12:38
• Updated: 06/Mar/23 13:44
• Resolved: 13/Oct/22 06:07

Description

Every new instance of org.apache.struts2.interceptor.BackgroundProcess spawns a new Thread (see constructor), no thread pooling is used.

Besides problems in environments where some container might need to manage the creation of threads, this issue also prevents certain performance/efficiency optimizations via ThreadLocal from taking full effect. E.g.: We use ThreadLocals for Random and SimpleDateFormat and those thread local instances "are lost" when a new Thread is created.

Therefore BackgroundProcess should be given a new constructor that takes a java.util.concurrent.Executor instance that is used to execute the Runnable.

Issue Links

• links to: GitHub Pull Request #187
• links to: GitHub Pull Request #609