[WW-3581] DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Not A Problem
• Affects Version/s: 2.2.1
• Component/s: Core Actions
• Assignee: Unassigned
• Reporter: Xiaoming Shi
• Created: 25/Feb/11 01:44
• Updated: 25/Feb/11 03:08
• Resolved: 25/Feb/11 03:08

Description

In the file
./struts-2.2.1/src/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java line:547

DateFormat.getDateTimeInstance() is called 3 times for each function call of "parseDateString"

We can add a class field to store the instances to improve performance.

Similar code can be found in (./struts-2.2.1/src/xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkBasicConverter.java line: 323)

(Similar to the Appache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778 )