[WW-3411] query string decoding error in URLHelper.parseQueryString

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.8.1
• Fix Version/s: 2.2.1
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Sean Ford
• Created: 19/Mar/10 17:40
• Updated: 28/Oct/12 22:08
• Resolved: 25/Mar/10 12:15

Description

There is a bug in URLHelper.parseQueryString() when dealing with keys in a query string that are URL Encoded.

Example:
UrlHelper.parseQueryString("a%3Ca=1") returns a map

{"a%3Ca" : "1"}

. Note, the key is still URL Encoded.

The problem becomes apparent if you use <s:url> with includeParams="all", which will grab parameters from both the query string and request parameterMap to include into a URL.

Example:
Request URL: /myAction.action?a<a=1
Generated URL by <s:url>: /myAction.action?a<a=1&a%3Ca=1
Expected URL: /myAction.action?a%3Ca=1

Note how "a<a" exists two times in the <s:url> URL, one encoded and one decoded. "a<a" is grabbed from the parameterMap where the servlet container will automatically decode the key. "a%3Ca" is grabbed from the query string by the UrlHelper.parseQueryString (who doesn't decode the key).

The fix is relatively simple (see patch)... I think parseQueryString just needs to call translatedAndDecode on the parameter name.