[WW-2902] Session token usage error: java.lang.IllegalStateException: Context has not been prepared for next connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.2
• Fix Version/s: 2.1.3
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: Sitaram Reddy
• Created: 01/Dec/08 22:13
• Updated: 28/Oct/12 22:07
• Resolved: 02/Dec/08 19:13

Description

I have looked into the source code and found the reason. In TokenInterceptor.doIntercept(...), there is this code:

Map session = ActionContext.getContext().getSession();

synchronized (session) {
if (!TokenHelper.validToken())

{ return handleInvalidToken(invocation); }

return handleValidToken(invocation);
}

This block is essentially not synchronized! I found that the session Map is not a unique object across requests within an user session - in contrast with the HttpSession object provided by the Servlet API. Perhaps that should be considered the real bug?

A previous bug WW-1786 also points out that the above block is not synchronized - that fix would be redundant once this issue is resolved.

Issue Links

• incorporates: WW-1786 using session-token interceptor generates FreeMarker template error
• is related to: WW-2905 ExecuteAndWaitInterceptor: Synchronize on HttpSession rather than session map from context