[WW-2893] XWorkConverter calling e.printStackTrace() after bad user input

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.2
• Fix Version/s: 2.1.3

Environment

Tomcat 6.0.18

• Assignee: Musachy Barroso
• Reporter: Lucas Nelson
• Created: 25/Nov/08 00:42
• Updated: 28/Oct/12 22:11
• Resolved: 01/Dec/08 22:45

Description

We are getting log output triggered by bad user input from the XWorkConverter#convertValue method - lines 302, 315, 326 in 2.1.2. This can be triggered by having a numeric field and not submitting anything in it, or having a custom converter that throws a TypeConversionException.

We would have difficulty going into production with bad user input triggering a stack dump in our log files - the frequency of bad input coupled with the computation cost of generating a stack trace, and the log file spam it would generate. Could these printStackTrace() calls please be removed. Perhaps replaced with debug level output.

IMO having application log output being generated by end-user activity is a problem.