[WW-2834] LocalizedTextUtil messageFormats cache is NOT thread safe

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.11.2
• Fix Version/s: 2.1.3
• Component/s: Core Interceptors
• Flags: Important
• Assignee: Unassigned
• Reporter: Kirk Rasmussen
• Created: 08/Oct/08 22:11
• Updated: 28/Oct/12 22:08
• Resolved: 18/Dec/08 19:24

Description

Here is a snippet from com.opensymphony.xwork2.util.LocalizedTextUtil that illustrates one (could be more) problem. This could be easily fixed by using the JDK 1.5 ConcurrentHashMap collection instead. I guess technically this is an XWork problem but it is used by the default TextProvider implementation.

private static final Map messageFormats = new HashMap();

private static MessageFormat buildMessageFormat(String pattern, Locale locale) {
MessageFormatKey key = new MessageFormatKey(pattern, locale);
MessageFormat format = (MessageFormat) messageFormats.get(key);
if (format == null)

{ format = new MessageFormat(pattern); format.setLocale(locale); format.applyPattern(pattern); messageFormats.put(key, format); }

return format;
}

Also the MessageFormat class itself is not thread safe and must be syncronized.