[WW-2825] StaticParametersInterceptor calls setters twice within interceptor code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.11.2
• Fix Version/s: 2.1.3
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: Kirk Rasmussen
• Created: 02/Oct/08 18:17
• Updated: 28/Oct/12 22:11
• Resolved: 09/Dec/08 18:39

Description

com.opensymphony.xwork2.interceptor.StaticParametersInterceptor will currently call the setter twice for each static property. It looks like the intention was to call it with either the naked value or parse the value as an OGNL expression but currently it is calling the setter twice regardless, i.e.

for (Iterator iterator = parameters.entrySet().iterator();
iterator.hasNext() {
Map.Entry entry = (Map.Entry) iterator.next();
(1) stack.setValue(entry.getKey().toString(), entry.getValue());
Object val = entry.getValue();
if (parse && val instanceof String)

{ val = TextParseUtil.translateVariables((String) val, stack); }
(2) stack.setValue(entry.getKey().toString(), val);
}


I believe the intention was:

for (Iterator iterator = parameters.entrySet().iterator();
iterator.hasNext() {
Map.Entry entry = (Map.Entry) iterator.next();
Object val = entry.getValue();
if (parse && val instanceof String) { val = TextParseUtil.translateVariables((String) val, stack); }

stack.setValue(entry.getKey().toString(), val);
}