Struts 2
  1. Struts 2
  2. WW-2801

Upgrade Tiles Plugin to support Tiles 2.1 - RendererFactory not specified - java.lang.IllegalStateException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.3.14
    • Component/s: Plugin - Tiles
    • Labels:
      None
    • Environment:

      mac, tomcat6, jdk5, struts2.1.2

      Description

      Attached sample webapp showing exception. It is a struts2-blank with tiles 2.1.0 added.

      Alvin

      1. struts2-blank-tiles2.1.0.tar.gz
        3.97 MB
        Alvin Singh
      2. 01-Homepage-GateIn.png
        49 kB
        Maxime Gréau
      3. 03-About-GateIn.png
        55 kB
        Maxime Gréau
      4. 02-Edit-GateIn.png
        40 kB
        Maxime Gréau

        Activity

        Hide
        Lukasz Lenart added a comment -

        New plugin was added to support Tiles 3

        Show
        Lukasz Lenart added a comment - New plugin was added to support Tiles 3
        Hide
        Lukasz Lenart added a comment -

        I think this issue can be closed as there is a new plugin which supports Tiles 3 right now.

        Show
        Lukasz Lenart added a comment - I think this issue can be closed as there is a new plugin which supports Tiles 3 right now.
        Hide
        Maxime Gréau added a comment -

        Ok for a new plugin.

        I think it's not the good issue since I don't upgrade Tiles version (I'm still using version 2.0.6).
        As you write in your comment, the target issues for this patch are https://issues.apache.org/jira/browse/WW-2749 and https://issues.apache.org/jira/browse/WW-2682 so I suggest you to move my comments, patchs and sample to WW-2749. What do you think about that ?

        Show
        Maxime Gréau added a comment - Ok for a new plugin. I think it's not the good issue since I don't upgrade Tiles version (I'm still using version 2.0.6). As you write in your comment, the target issues for this patch are https://issues.apache.org/jira/browse/WW-2749 and https://issues.apache.org/jira/browse/WW-2682 so I suggest you to move my comments, patchs and sample to WW-2749 . What do you think about that ?
        Hide
        Lukasz Lenart added a comment -

        or maybe create a new plugin - struts2-portlet-tiles and move the new result there ?

        Show
        Lukasz Lenart added a comment - or maybe create a new plugin - struts2-portlet-tiles and move the new result there ?
        Hide
        Maxime Gréau added a comment -

        In fact, it solves also this issues (2749, 2682).

        I can update this patch with all changes (java and xml) only in struts-tiles-plugin source code but, in this case, it will be Tiles plugin which will depend on Portlet plugin.

        In addition, I will update struts2-portlet project with a tiles example.

        Show
        Maxime Gréau added a comment - In fact, it solves also this issues (2749, 2682). I can update this patch with all changes (java and xml) only in struts-tiles-plugin source code but, in this case, it will be Tiles plugin which will depend on Portlet plugin. In addition, I will update struts2-portlet project with a tiles example.
        Hide
        Lukasz Lenart added a comment - - edited

        As I understand, the patch solves also the connected issues - WW-2749 and WW-2682 ?

        The only problem I see is that right now Portlet plugins depends on Tiles plugin, which can be harmful for users which don't use Tiles :/

        Show
        Lukasz Lenart added a comment - - edited As I understand, the patch solves also the connected issues - WW-2749 and WW-2682 ? The only problem I see is that right now Portlet plugins depends on Tiles plugin, which can be harmful for users which don't use Tiles :/
        Hide
        Maxime Gréau added a comment - - edited

        I attach a patch based on SVN trunk and a sample application which validate that Portlet 2.0 works with Tiles Plugin

        Show
        Maxime Gréau added a comment - - edited I attach a patch based on SVN trunk and a sample application which validate that Portlet 2.0 works with Tiles Plugin
        Hide
        Maxime Gréau added a comment -

        I attached a sample application which shows how tiles 2.0.6 work with portlet 2 and struts 2.3.4.
        This app has been tested in GateIn 3.3.0-GA with Tomcat 6.

        Show
        Maxime Gréau added a comment - I attached a sample application which shows how tiles 2.0.6 work with portlet 2 and struts 2.3.4. This app has been tested in GateIn 3.3.0-GA with Tomcat 6.
        Hide
        Lukasz Lenart added a comment -

        Would be nice

        Show
        Lukasz Lenart added a comment - Would be nice
        Hide
        Maxime Gréau added a comment -

        do you want a sample application with that patches ? I can atatch it next week

        Show
        Maxime Gréau added a comment - do you want a sample application with that patches ? I can atatch it next week
        Hide
        Lukasz Lenart added a comment -

        Thanks for reporting, I'll move that patches to 2.3.5 version then

        Show
        Lukasz Lenart added a comment - Thanks for reporting, I'll move that patches to 2.3.5 version then
        Hide
        Maxime Gréau added a comment -

        Hi,
        We use Struts 2 / Portlet 2 with tiles 2.0.6 since 2009 in a production environnement, if any examples can help.

        Since 2009 we use :

        • JBoss Portal 2.7.2
        • Portlets with Struts 2.1.2 (struts2-portlet2-plugin-2.1.2 from sandbox) + Tiles 2.0.6 (from struts2-tiles-plugin) + Patchs JIRA WW-2749 + JIRA WW-2682 + JIRA WW-2720

        Since 3 months we update our architecture to :

        • Gatein (eXo)
        • Portlets with Struts 2.3.3 + Tiles 2.0.6 (from struts2-tiles-plugin) + Patchs JIRA WW-2749 + JIRA WW-2682

        Regards

        Show
        Maxime Gréau added a comment - Hi, We use Struts 2 / Portlet 2 with tiles 2.0.6 since 2009 in a production environnement, if any examples can help. Since 2009 we use : JBoss Portal 2.7.2 Portlets with Struts 2.1.2 (struts2-portlet2-plugin-2.1.2 from sandbox) + Tiles 2.0.6 (from struts2-tiles-plugin) + Patchs JIRA WW-2749 + JIRA WW-2682 + JIRA WW-2720 Since 3 months we update our architecture to : Gatein (eXo) Portlets with Struts 2.3.3 + Tiles 2.0.6 (from struts2-tiles-plugin) + Patchs JIRA WW-2749 + JIRA WW-2682 Regards
        Hide
        Lukasz Lenart added a comment -

        Any help would be appreciated as I even don't know where to start

        Thanks in advance

        Lukasz

        Show
        Lukasz Lenart added a comment - Any help would be appreciated as I even don't know where to start Thanks in advance – Lukasz
        Hide
        Chad Sears added a comment -

        I don't see where this is planned in any release right now, is there a work around I can use in the time being?

        Show
        Chad Sears added a comment - I don't see where this is planned in any release right now, is there a work around I can use in the time being?
        Hide
        Alvin Singh added a comment -

        Hasn't been any movement on this for awhile - I would create a patch myself but the renderer code is a little complicated (I tried!). Not sure who has contributed to yet to see if they could help. As mentioned in comment above this is a high valuable fix for a lot of tiles/struts users.

        Show
        Alvin Singh added a comment - Hasn't been any movement on this for awhile - I would create a patch myself but the renderer code is a little complicated (I tried!). Not sure who has contributed to yet to see if they could help. As mentioned in comment above this is a high valuable fix for a lot of tiles/struts users.
        Hide
        David Canós added a comment -

        tiles 2.1.X is not beta.
        is ready to use in production.

        it supports wildcards on definitions a must have for tiles-plugins users
        improvements in tiles 2.1:
        http://tiles.apache.org/framework/whats-new.html

        Show
        David Canós added a comment - tiles 2.1.X is not beta. is ready to use in production. it supports wildcards on definitions a must have for tiles-plugins users improvements in tiles 2.1: http://tiles.apache.org/framework/whats-new.html
        Hide
        Antonio Petrelli added a comment -

        Extension developers (like in Struts 2) are heavily impacted by changes in Tiles 2.1, while users are not.

        Show
        Antonio Petrelli added a comment - Extension developers (like in Struts 2) are heavily impacted by changes in Tiles 2.1, while users are not.
        Hide
        James Holmes added a comment -

        I haven't dug into this, but am curious if it is possible to modify StrutsTilesContainerFactory to work with both Tiles 2.0.x and Tiles 2.1.x?

        It looks like Tiles 2.1.x is still in beta so I don't think we'd change the Struts code to only support that yet.

        Show
        James Holmes added a comment - I haven't dug into this, but am curious if it is possible to modify StrutsTilesContainerFactory to work with both Tiles 2.0.x and Tiles 2.1.x? It looks like Tiles 2.1.x is still in beta so I don't think we'd change the Struts code to only support that yet.
        Hide
        Antonio Petrelli added a comment -

        Moved to Struts since it is a bug of the Struts 2/Tiles 2 plugin.
        The StrutsTilesContainerFactory is not compatible with Tiles 2.1.x.

        Show
        Antonio Petrelli added a comment - Moved to Struts since it is a bug of the Struts 2/Tiles 2 plugin. The StrutsTilesContainerFactory is not compatible with Tiles 2.1.x.

          People

          • Assignee:
            Lukasz Lenart
            Reporter:
            Alvin Singh
          • Votes:
            6 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development